Skip to content

Conversation

@IllianiBird
Copy link
Collaborator

Requires Improvement: Added Final Batch of Elective Surgeries to Alt Advanced Medical

This PR creates AAM versions of the following 'special' injuries:

  • Postpartum Recovery
  • Transit Disorientation Syndrome
  • Crippling Flashbacks
  • Childlike Regression
  • Chronic Disassociation

All five injuries apply the 'Stress' effect, which applies a -1 penalty to all Attribute scores (a significant reduction in the impact of these injuries). Discontinuation Syndrome now also applies the 'Stress' effect instead of its previous effects. As with all other AAM injuries, multiple sources of Stress will stack.

While doing the above I also added a 3-in-4 chance that a Berserker character will be restrained by those around them, before they can do any harm.

Finally I tidied up the Transit Disorientation Syndrome code and fixed a couple of bugs related to the above injuries.

…al' Injuries; Reduced Impact of Mental Breaks
@IllianiBird IllianiBird self-assigned this Nov 20, 2025
@IllianiBird IllianiBird requested a review from a team as a code owner November 20, 2025 06:06
@IllianiBird IllianiBird added Bug Severity: Low Issues described as low severity as per the new issue form Improvement to Existing Feature Used with the RFE tag to indicate an improvement to an existing feature labels Nov 20, 2025
@HammerGS HammerGS requested a review from Copilot November 21, 2025 02:36
Copilot finished reviewing on behalf of HammerGS November 21, 2025 02:41
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds Alternative Advanced Medical (AAM) versions of five "special" injuries that occur from character flaws and childbirth, changing their effect from multiple severe attribute penalties to a single unified "STRESS" effect (-1 to all attributes). The changes also add a restraint mechanic for berserker characters and refactor the Transit Disorientation Syndrome code for better maintainability.

  • Introduces AAM versions of Postpartum Recovery, Transit Disorientation Syndrome, Crippling Flashbacks, Childlike Regression, and Chronic Dissociation injuries, all applying the new STRESS effect
  • Adds a 75% chance that berserker characters are restrained before causing harm
  • Refactors Transit Disorientation Syndrome application logic into dedicated helper methods

Reviewed Changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
PersonTest.java Updated test method signatures to include new isUseAltAdvancedMedical parameter
AbstractProcreation.java Added AAM version of Postpartum Recovery injury with non-stacking logic
InjurySubType.java Added FLAW subtype for injuries caused by character flaws
InjuryEffect.java Renamed DISCONTINUATION_SYNDROME effect to STRESS
AlternateInjuries.java Added five new AAM injury classes for flaw-related mental conditions
AdvancedMedicalAlternate.java Added hasInjuryOfType utility method for checking injury existence
InjuryTypes.java Registered new AAM injury types with sequential IDs 184-188
Person.java Updated injury processing methods to support AAM versions and added berserker restraint logic
CurrentLocation.java Refactored Transit Disorientation Syndrome logic into helper methods
CampaignNewDayManager.java Added isUseAltAdvancedMedical parameter to injury processing calls
Personnel.properties Added berserker restraint message
InjuryEffect.properties Updated effect name from DISCONTINUATION_SYNDROME to STRESS
AlternateInjuries.properties Added display names for five new AAM injuries

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Improvement to Existing Feature Used with the RFE tag to indicate an improvement to an existing feature Severity: Low Issues described as low severity as per the new issue form

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant