Skip to content

Conversation

@psikomonkie
Copy link
Member

@psikomonkie psikomonkie commented Nov 20, 2025

Fixes #8226

Don't merge until MegaMek/megamek#7651 is merged.

@psikomonkie psikomonkie requested a review from a team as a code owner November 20, 2025 23:59
Copy link
Collaborator

@IllianiBird IllianiBird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might need to update this PR when you merge the MM half, for GitHub to pick up that it's all kosher. But zero issues insofar as I can see them.

@codecov
Copy link

codecov bot commented Nov 21, 2025

Codecov Report

❌ Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 11.72%. Comparing base (cddd9fc) to head (f130d04).
⚠️ Report is 21 commits behind head on main.

Files with missing lines Patch % Lines
MekHQ/src/mekhq/campaign/unit/Unit.java 0.00% 4 Missing ⚠️
...kHQ/src/mekhq/campaign/ResolveScenarioTracker.java 0.00% 1 Missing ⚠️
.../src/mekhq/campaign/mission/CrewSkillUpgrader.java 0.00% 0 Missing and 1 partial ⚠️
MekHQ/src/mekhq/gui/adapter/TOEMouseAdapter.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #8270      +/-   ##
============================================
- Coverage     11.73%   11.72%   -0.01%     
+ Complexity     7536     7532       -4     
============================================
  Files          1271     1271              
  Lines        162721   162724       +3     
  Branches      24515    24515              
============================================
- Hits          19095    19082      -13     
- Misses       141628   141644      +16     
  Partials       1998     1998              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@psikomonkie psikomonkie merged commit 148b2d0 into MegaMek:main Nov 21, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Issue] Certain HHW allow Crew Other to be assigned

2 participants