Skip to content

Conversation

@IllianiBird
Copy link
Collaborator

InjuryEffect.BONE_AND_JOIN_REINFORCEMENT.name -> InjuryEffect.BONE_REINFORCEMENT.name

@IllianiBird IllianiBird self-assigned this Nov 21, 2025
@IllianiBird IllianiBird requested a review from a team as a code owner November 21, 2025 01:43
@IllianiBird IllianiBird added Severity: Low Issues described as low severity as per the new issue form Text Issues related to text, translations, formatting labels Nov 21, 2025
@codecov
Copy link

codecov bot commented Nov 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 11.73%. Comparing base (0dfb268) to head (659aa54).
⚠️ Report is 43 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #8273   +/-   ##
=========================================
  Coverage     11.73%   11.73%           
- Complexity     7531     7537    +6     
=========================================
  Files          1271     1271           
  Lines        162693   162723   +30     
  Branches      24505    24516   +11     
=========================================
+ Hits          19084    19099   +15     
- Misses       141608   141629   +21     
+ Partials       2001     1995    -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@HammerGS HammerGS requested a review from Copilot November 21, 2025 02:25
Copilot finished reviewing on behalf of HammerGS November 21, 2025 02:26
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR corrects a typo in the resource bundle key for the Reinforced Bones injury effect. The property key was incorrectly named BONE_AND_JOIN_REINFORCEMENT (with a misspelling of "joint" as "join") when it should be BONE_REINFORCEMENT to match the actual enum constant defined in the Java code.

  • Fixes the resource bundle key name to match the InjuryEffect.BONE_REINFORCEMENT enum constant used throughout the codebase

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@HammerGS HammerGS merged commit 4280b7b into MegaMek:main Nov 21, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Severity: Low Issues described as low severity as per the new issue form Text Issues related to text, translations, formatting

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants