Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Remove BaseControllerV1 #5018

Draft
wants to merge 21 commits into
base: main
Choose a base branch
from
Draft

chore: Remove BaseControllerV1 #5018

wants to merge 21 commits into from

Conversation

MajorLift
Copy link
Contributor

Explanation

References

Changelog

@metamask/package-a

  • : Your change here
  • : Your change here

@metamask/package-b

  • : Your change here
  • : Your change here

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@MajorLift
perf: Convert reduce operations to re-use output object instead of cr…
2a4a115 
…eating new tmp object every iteration
@MajorLift
fix: incorrect logic for assigning fall-back metadata properties for …
2612d4a 
…non-V2 controllers
@MajorLift
fix: type issue with assigning property to generic type
87fc3f6
@MajorLift
feat: **BREAKING:** Re-define controllers constructor option from a…
2a18840 
…rray to object
@MajorLift
fix: Check that input is V1/V2 controller when instantiating Composab…
7b0be9f 
…leController state and metadata fields
@MajorLift
test: Update tests
871486a
@MajorLift
Update changelogs
c103016
@MajorLift
Update comments
c570e26
@MajorLift
perf: Replace Object.assign with property assignments
901e8b4
@MajorLift
Assign metadata to each child controller instead of to individual nes…
55af3a6 
…ted properties of child controller state
@MajorLift
Remove non-controller properties from state, metadata fields
c533f7c
@MajorLift
test: fix missing stateChange events in test composable-controller …
c1a4670 
…messenger events allowlists
@MajorLift
Update jsdoc comments
5b94171
@MajorLift
Fix undefined property deletion behavior
571a483
@MajorLift
Apply eslint-disable to entire test file to allow PascalCase contro…
77fb0e8 
…ller name object keys
@MajorLift
Fix types
a7e7296
@MajorLift
Update changelog
b23ef8e
@MajorLift
Wrap delete operations for non-controllers in try-catch block
c420da0
@MajorLift
Add tests for stateChange events that are not defined or omitted fr…
518eaa7 
…om allowlist
@MajorLift
Update packages/composable-controller/CHANGELOG.md
244f6c8
@MajorLift MajorLift force-pushed the jongsun/perf/composable-controller/241124-remove-expensive-reduce branch from a0b32c1 to 244f6c8 Compare December 3, 2024 15:04
@MajorLift MajorLift force-pushed the jongsun/refactor/base-controller/241203-remove-BaseControllerV1 branch 2 times, most recently from 8da2eda to 5f12a92 Compare December 3, 2024 15:31
@MajorLift MajorLift force-pushed the jongsun/refactor/base-controller/241203-remove-BaseControllerV1 branch from 5f12a92 to 7800e9b Compare December 3, 2024 15:36
Base automatically changed from jongsun/perf/composable-controller/241124-remove-expensive-reduce to main December 5, 2024 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@MajorLift