Code

chore: Remove BaseControllerV1#5018

Code

Draft

MajorLift wants to merge 21 commits intomainMetaMask/core:mainfrom jongsun/refactor/base-controller/241203-remove-BaseControllerV1MetaMask/core:jongsun/refactor/base-controller/241203-remove-BaseControllerV1Copy head branch name to clipboard

+277-847

Commits

Commits on Dec 3, 2024

• perf: Convert reduce operations to re-use output object instead of creating new tmp object every iteration

  MajorLift

  committed
  2a4a115

• fix: incorrect logic for assigning fall-back metadata properties for non-V2 controllers

  MajorLift

  committed
  2612d4a

• fix: type issue with assigning property to generic type

  MajorLift

  committed
  87fc3f6

• feat: **BREAKING:** Re-define controllers constructor option from array to object

  MajorLift

  committed
  2a18840

• fix: Check that input is V1/V2 controller when instantiating ComposableController state and metadata fields

  MajorLift

  committed
  7b0be9f

• test: Update tests

  MajorLift

  committed
  871486a

• Update changelogs

  MajorLift

  committed
  c103016

• Update comments

  MajorLift

  committed
  c570e26

• perf: Replace Object.assign with property assignments

  MajorLift

  committed
  901e8b4

• Assign metadata to each child controller instead of to individual nested properties of child controller state

  MajorLift

  committed
  55af3a6

• Remove non-controller properties from state, metadata fields

  MajorLift

  committed
  c533f7c

• test: fix missing stateChange events in test composable-controller messenger events allowlists

  MajorLift

  committed
  c1a4670

• Update jsdoc comments

  MajorLift

  committed
  5b94171

• Fix undefined property deletion behavior

  MajorLift

  committed
  571a483

• Apply eslint-disable to entire test file to allow PascalCase controller name object keys

  MajorLift

  committed
  77fb0e8

• Fix types

  MajorLift

  committed
  a7e7296

• Update changelog

  MajorLift

  committed
  b23ef8e

• Wrap delete operations for non-controllers in try-catch block

  MajorLift

  committed
  c420da0

• Add tests for stateChange events that are not defined or omitted from allowlist

  MajorLift

  committed
  518eaa7

• Update packages/composable-controller/CHANGELOG.md

  MajorLift

  committed
  244f6c8

• stash

  MajorLift

  committed
  7800e9b