fix: Signature methods failing silently when the wallet is locked and the user is opted in to MetaMetrics

[jiexi]

Description

Fixes a bug where the wallet would not prompt the user for unlock and would silently drop personal_sign requests when the wallet was locked and the user was opted into MetaMetrics.

This was caused by the KeyringController throwing when trying to resolve account and hardware info in the RPCTrackingMiddleware when receiving a request that maps to a SignatureRequested event. The fix is was to:

1. check if the KeyringController is locked or not and to not try to resolve hardware/account info if it is locked
2. attempt to resolve hardware/account info again when a SignatureRequested request is rejected/accepted to ensure we still capture the attributes if possible

Changelog

CHANGELOG entry: Fixed a bug where the wallet would not prompt the user for unlock and would silently drop personal_sign requests when the wallet was locked and the user was opted into MetaMetrics

Related issues

Fixes: https://consensys.slack.com/archives/C8RSKCNCD/p1760586496588449

Manual testing steps

1. Opt into MetaMetrics
2. Goto https://metamask.github.io/test-dapp/
3. Connect
4. Lock your wallet
5. In console enter await window.ethereum.request({method: 'personal_sign', params: ['message', window.ethereum.selectedAddress]})
6. You should get prompted for unlock
7. If you close the window, the request should immediately resolve with a rejection. If you unlock and accept the approval, you should get a normal response

Screenshots/Recordings

Before

Screen.Recording.2025-10-17.at.12.02.28.PM.mov

After

Screen.Recording.2025-10-17.at.11.56.48.AM.mov

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

---

Note

Ensure signature tracking doesn’t fail when the wallet is locked by skipping hardware/account lookups until unlocked, retrying on approval/rejection, and expanding tests and messenger permissions.

• Metametrics tracking:
  • Signature middleware now re-attempts resolving snap/hardware info on signature finalize (Approved/Rejected) and merges into eventProperties.
  • Fetches snap/hardware info at request time as before.
• Snap/Hardware metrics utility (app/scripts/lib/snap-keyring/metrics.ts):
  • Adds KeyringController:getState usage; only resolves account_type, device_model, and account_hardware_type when wallet is unlocked.
  • Always includes snap metadata when available.
  • Extends messenger allowed actions to include KeyringController:getState.
• Controller wiring (app/scripts/metamask-controller.js):
  • Grants KeyringController:getState to SnapAndHardwareMessenger used by RPC tracking middleware.
• Tests:
  • Add mocks and assertions that snap/hardware info is requested on SignatureRequested, and retried on SignatureApproved/SignatureRejected.
  • Expand metrics.test.ts with locked/unlocked and HD/Snap account scenarios, and call-order expectations.

^{Written by Cursor Bugbot for commit 98eb1c5. This will update automatically on new commits. Configure here.}

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[metamaskbot]

✨ Files requiring CODEOWNER review ✨

🔑 @MetaMask/accounts-engineers (2 files, +264 -125)

• 📁 app/
  • 📁 scripts/
    • 📁 lib/
      • 📁 snap-keyring/
        • 📄 metrics.test.ts +241 -114
        • 📄 metrics.ts +23 -11

---

👨‍🔧 @MetaMask/wallet-integrations (1 files, +14 -0)

• 📁 app/
  • 📁 scripts/
    • 📁 lib/
      • 📄 createRPCMethodTrackingMiddleware.js +14 -0

[metamaskbot]

📊 Page Load Benchmark Results

Current Commit: 23d5d8e | Date: 10/17/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

• pageLoadTime-> current mean value: 1.04s (±69ms) 🟡 | historical mean value: 1.05s ⬇️ (historical data)
• domContentLoaded-> current mean value: 734ms (±67ms) 🟢 | historical mean value: 737ms ⬇️ (historical data)
• firstContentfulPaint-> current mean value: 78ms (±12ms) 🟢 | historical mean value: 77ms ⬆️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.04s	69ms	992ms	1.32s	1.25s	1.32s
domContentLoaded	734ms	67ms	691ms	1.01s	934ms	1.01s
firstPaint	78ms	12ms	60ms	172ms	92ms	172ms
firstContentfulPaint	78ms	12ms	60ms	172ms	92ms	172ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

---

Results generated automatically by MetaMask CI

[metamaskbot]

Builds ready [23d5d8e]

• builds: chrome, firefox
• builds (beta): chrome, firefox
• builds (flask): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• bundle size: Bundle Size Stats
• user-actions-benchmark: User Actions Stats
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7, 8
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
  • ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
  • content-script: 0
  • offscreen: 0

UI Startup Metrics (1258 ± 61 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1258	1139	1390	61	1310	1361
			load	1084	973	1210	58	1130	1181
			domContentLoaded	1078	968	1204	57	1125	1162
			domInteractive	18	14	52	7	17	37
			firstPaint	648	92	1206	441	1100	1156
			backgroundConnect	254	240	302	9	257	267
			firstReactRender	25	18	52	5	27	36
			getState	15	5	49	8	19	33
			initialActions	4	0	34	4	5	7
			loadScripts	830	716	963	56	876	922
			setupStore	9	6	22	2	11	15
	Webpack	Home	uiStartup	836	718	1075	71	852	1007
			load	633	583	927	76	634	829
			domContentLoaded	625	578	910	74	626	820
			domInteractive	15	11	44	8	14	37
			firstPaint	193	56	939	189	193	602
			backgroundConnect	21	11	50	7	27	34
			firstReactRender	27	17	107	10	31	33
			getState	9	4	17	3	11	13
			initialActions	3	0	8	2	4	6
			loadScripts	622	576	899	72	624	808
			setupStore	10	5	16	2	12	13
Firefox	Browserify	Home	uiStartup	1464	1241	1879	132	1516	1721
			load	1243	1070	1506	93	1302	1425
			domContentLoaded	1242	1069	1506	93	1302	1425
			domInteractive	114	34	337	55	115	271
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	33	21	104	12	37	49
			firstReactRender	25	21	70	6	26	32
			getState	9	3	78	8	10	17
			initialActions	6	2	74	10	4	21
			loadScripts	1220	1052	1487	91	1279	1397
			setupStore	14	5	203	24	10	33
	Webpack	Home	uiStartup	1587	1388	1992	120	1633	1842
			load	1361	1206	1668	91	1439	1523
			domContentLoaded	1360	1204	1668	91	1438	1523
			domInteractive	106	33	385	65	111	307
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	39	22	188	21	42	69
			firstReactRender	29	21	78	11	31	49
			getState	8	4	52	5	8	13
			initialActions	6	2	72	11	3	13
			loadScripts	1336	1188	1634	88	1414	1488
			setupStore	14	5	177	24	10	51

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 290 Bytes (0.01%)
• ui: 0 Bytes (0%)
• common: 10 Bytes (0%)

[metamaskbot]

📊 Page Load Benchmark Results

Current Commit: 98eb1c5 | Date: 10/17/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

• pageLoadTime-> current mean value: 1.04s (±70ms) 🟡 | historical mean value: 1.04s ⬆️ (historical data)
• domContentLoaded-> current mean value: 737ms (±68ms) 🟢 | historical mean value: 734ms ⬆️ (historical data)
• firstContentfulPaint-> current mean value: 78ms (±14ms) 🟢 | historical mean value: 77ms ⬆️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.04s	70ms	1.00s	1.32s	1.25s	1.32s
domContentLoaded	737ms	68ms	699ms	998ms	940ms	998ms
firstPaint	78ms	14ms	60ms	200ms	88ms	200ms
firstContentfulPaint	78ms	14ms	60ms	200ms	88ms	200ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

---

Results generated automatically by MetaMask CI

[metamaskbot]

Builds ready [98eb1c5]

• builds: chrome, firefox
• builds (beta): chrome, firefox
• builds (flask): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• bundle size: Bundle Size Stats
• user-actions-benchmark: User Actions Stats
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7, 8
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
  • ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
  • content-script: 0
  • offscreen: 0

UI Startup Metrics (1230 ± 64 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1230	1105	1396	64	1274	1354
			load	1061	959	1184	58	1093	1177
			domContentLoaded	1055	954	1178	57	1086	1172
			domInteractive	18	13	129	13	16	41
			firstPaint	715	85	1194	423	1082	1146
			backgroundConnect	249	237	273	6	252	259
			firstReactRender	26	18	46	6	27	41
			getState	16	6	87	10	19	32
			initialActions	7	0	41	7	9	20
			loadScripts	812	712	935	57	839	924
			setupStore	11	5	25	5	12	22
	Webpack	Home	uiStartup	823	712	1086	65	842	923
			load	622	575	916	67	630	765
			domContentLoaded	614	571	909	66	621	757
			domInteractive	14	11	41	6	13	34
			firstPaint	199	57	897	195	191	627
			backgroundConnect	21	11	44	7	25	32
			firstReactRender	26	16	57	8	31	35
			getState	9	3	20	3	11	14
			initialActions	3	0	11	2	4	7
			loadScripts	612	569	898	63	619	747
			setupStore	9	5	28	3	11	12
Firefox	Browserify	Home	uiStartup	1419	1226	1831	111	1473	1601
			load	1211	1066	1420	80	1265	1377
			domContentLoaded	1211	1066	1420	80	1265	1377
			domInteractive	112	35	299	50	120	241
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	37	23	100	17	39	86
			firstReactRender	25	20	61	6	25	36
			getState	9	3	48	7	8	32
			initialActions	4	1	47	6	3	10
			loadScripts	1185	1050	1397	77	1231	1329
			setupStore	11	5	108	12	10	30
	Webpack	Home	uiStartup	1654	1474	2100	122	1689	1934
			load	1415	1234	1668	89	1470	1589
			domContentLoaded	1414	1233	1668	89	1470	1588
			domInteractive	118	32	380	72	115	357
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	42	23	135	18	46	88
			firstReactRender	30	23	73	8	33	42
			getState	11	4	169	17	10	16
			initialActions	4	1	45	5	4	8
			loadScripts	1387	1214	1641	87	1434	1562
			setupStore	16	6	262	31	10	74

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 307 Bytes (0.01%)
• ui: 0 Bytes (0%)
• common: 10 Bytes (0%)