Skip to content

Conversation

n3ps
Copy link
Contributor

@n3ps n3ps commented Oct 17, 2025

Description

Transaction polling already starts as soon as the Activity tab component is loaded. Removing the extra call on tab click.

Changelog

CHANGELOG entry: chore: remove extra transactions call

Related issues

Fixes:

Manual testing steps

  1. Open Network panel
  2. Go to Activity tab
  3. Observe transactions api call

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Stops dispatching updateIncomingTransactions on Activity tab click and removes the thunk from ui/store/actions.ts.

  • UI:
    • ui/components/multichain/account-overview/account-overview-tabs.tsx: Stop dispatching updateIncomingTransactions when the Activity tab is clicked (keeps detectNfts on NFTs tab).
  • Store/Actions:
    • ui/store/actions.ts: Remove the updateIncomingTransactions thunk and related background call.

Written by Cursor Bugbot for commit ef26bea. This will update automatically on new commits. Configure here.

@n3ps n3ps marked this pull request as ready for review October 17, 2025 21:20
@n3ps n3ps requested review from a team as code owners October 17, 2025 21:20
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-core-extension-ux Core Extension UX team label Oct 17, 2025
@metamaskbot
Copy link
Collaborator

✨ Files requiring CODEOWNER review ✨

🔑 @MetaMask/accounts-engineers (1 files, +1 -4)
  • 📁 ui/
    • 📁 components/
      • 📁 multichain/
        • 📁 account-overview/
          • 📄 account-overview-tabs.tsx +1 -4

👨‍🔧 @MetaMask/core-extension-ux (1 files, +1 -4)
  • 📁 ui/
    • 📁 components/
      • 📁 multichain/
        • 📁 account-overview/
          • 📄 account-overview-tabs.tsx +1 -4

@metamaskbot
Copy link
Collaborator

📊 Page Load Benchmark Results

Current Commit: ef26bea | Date: 10/17/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.04s (±70ms) 🟡 | historical mean value: 1.04s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 731ms (±67ms) 🟢 | historical mean value: 734ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 77ms (±12ms) 🟢 | historical mean value: 77ms ⬇️ (historical data)
📈 Detailed Results
Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.04s 70ms 994ms 1.31s 1.24s 1.31s
domContentLoaded 731ms 67ms 693ms 990ms 924ms 990ms
firstPaint 77ms 12ms 60ms 176ms 88ms 176ms
firstContentfulPaint 77ms 12ms 60ms 176ms 88ms 176ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms

Results generated automatically by MetaMask CI

@metamaskbot
Copy link
Collaborator

Builds ready [ef26bea]
UI Startup Metrics (1217 ± 82 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1217109318198212551309
load104794615697410811141
domContentLoaded104094115597410721135
domInteractive1913139141640
firstPaint65089117641610471135
backgroundConnect2502372758254266
firstReactRender25196072839
getState1563672031
initialActions50315520
loadScripts797701129372829890
setupStore952331015
WebpackHomeuiStartup76966297458787901
load56953181852577674
domContentLoaded56252780951571666
domInteractive15114471335
firstPaint18049812187159665
backgroundConnect22104072537
firstReactRender26166393034
getState831531113
initialActions309247
loadScripts56052580150569658
setupStore942231114
FirefoxBrowserifyHomeuiStartup14671280206112515151686
load1248108514517912991409
domContentLoaded1248108414507912981409
domInteractive1152432156121270
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect3621158203857
firstReactRender25206772641
getState13421329837
initialActions41679313
loadScripts1223105914288112721385
setupStore11572111034
WebpackHomeuiStartup15471359211013015821858
load1332120017389713741525
domContentLoaded1332119917379713731524
domInteractive1043336467101348
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect331692133956
firstReactRender292275103056
getState93657815
initialActions7119826315
loadScripts1310118317159513491497
setupStore13588141054
Bundle size diffs [🚀 Bundle size reduced!]
  • background: 58 Bytes (0%)
  • ui: -76 Bytes (0%)
  • common: -271 Bytes (0%)

@n3ps n3ps enabled auto-merge October 18, 2025 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size-S team-core-extension-ux Core Extension UX team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants