Skip to content

chore: remove extra transactions api call #36968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −21
Open

chore: remove extra transactions api call #36968

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions ui/components/multichain/account-overview/account-overview-tabs.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ import {
getChainIdsToPoll,
getIsMultichainAccountsState2Enabled,
} from '../../../selectors';
import { detectNfts, updateIncomingTransactions } from '../../../store/actions';
import { detectNfts } from '../../../store/actions';
import AssetList from '../../app/assets/asset-list';
import DeFiTab from '../../app/assets/defi-list/defi-tab';
import { useAssetListTokenDetection } from '../../app/assets/hooks';
Expand Down Expand Up @@ -65,9 +65,6 @@ export const AccountOverviewTabs = ({
if (tabName === AccountOverviewTabKey.Nfts) {
dispatch(detectNfts(selectedChainIds));
}
if (tabName === AccountOverviewTabKey.Activity) {
dispatch(updateIncomingTransactions());
}
trackEvent({
category: MetaMetricsEventCategory.Home,
event: ACCOUNT_OVERVIEW_TAB_KEY_TO_METAMETRICS_EVENT_NAME_MAP[tabName],
Expand Down
17 changes: 0 additions & 17 deletions ui/store/actions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3387,23 +3387,6 @@ export function createSpeedUpTransaction(
};
}

export function updateIncomingTransactions(): ThunkAction<
void,
MetaMaskReduxState,
unknown,
AnyAction
> {
return async (dispatch) => {
log.debug(`background.updateIncomingTransactions`);
try {
await submitRequestToBackground('updateIncomingTransactions');
} catch (error) {
logErrorWithMessage(error);
dispatch(displayWarning('Had a problem updating incoming transactions!'));
}
};
}

export function createRetryTransaction(
txId: string,
customGasSettings: CustomGasSettings,
Expand Down
Loading