perf: Move request inspection outside of the executor #3356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrederikBolding
force-pushed
the
fb/move-request-inspection-outside-executor
branch
from
653abb1 to
9005464
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3356 +/- ##
==========================================
- Coverage 98.03% 98.01% -0.03%
==========================================
Files 402 402
Lines 11109 11084 -25
Branches 1754 1755 +1
==========================================
- Hits 10891 10864 -27
- Misses 218 220 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
FrederikBolding
force-pushed
the
fb/move-request-inspection-outside-executor
branch
from
0db0eba to
797d795
Compare
FrederikBolding
commented
Apr 28, 2025
| const fetchPromise = fetch(input, { | ||
| ...init, | ||
| signal: abortController.signal, | ||
| }); | ||
| await notify({ |
There was a problem hiding this comment.
Moving this so fetch can start before waiting for the notification to land
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 6, 2025
Moved some of the ideas from #3356 to this PR which will be a simple to merge right away. The other referenced PR needs some more work, but is eventually what we should do. This PR let's Snaps start their outbound request before waiting for the notification to land, this should be a small perf improvement to all requests made from the Snap.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.