Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cleanup=False to analysis specific config #45

Merged

Conversation

matrulda
Copy link
Contributor

@matrulda matrulda commented Jan 2, 2025

This PR adds cleanup = false for all analysis pipelines, since the setting was removed here: NationalGenomicsInfrastructure/miarka-provision#300

Since the config no longer is related to the GRCh38 reference only, I renamed it so it is clear that it is a general analysis config.

@matrulda matrulda requested a review from kjellinjonas January 2, 2025 13:34
@matrulda matrulda self-assigned this Jan 2, 2025
Copy link
Contributor

@kjellinjonas kjellinjonas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good solution. However, at the moment this will only work for RNA-seq since this is the only pipeline where we reference additional configs apart from the ones included in the aliases. The methylseq _templatea nd sarek_template files must be updated to include _CONFIG_ in the pipeline command.

@matrulda
Copy link
Contributor Author

Great point! I just assumed that it was in all templates and just looked at rnaseq to verify 🤦
I added the config to all templates and removed the parameters that specified the location of GRCh38 files, the same references/annotation files can be found under the default igenomes location.

@matrulda matrulda requested a review from kjellinjonas January 14, 2025 09:39
Copy link
Contributor

@kjellinjonas kjellinjonas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, I also approved the related PR "Revert cleanup = False for upps #300" in miarka-provision now that this is fixed

@matrulda
Copy link
Contributor Author

Thank you!

@matrulda matrulda merged commit d97a0ca into Molmed:master Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants