Remove inappropriate tags while create L2 or L1 feature frome low level feature #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 20, 2023 10:16
Remove inappropriate tags while create L2 L1 from lower level feature
Juke34
requested changes
Apr 21, 2023
Comment on lines
+1571
to
+1572
| if ($l1_feature->has_tag($tag)) { | ||
| $l1_feature->remove_tag($tag); |
There was a problem hiding this comment.
It must be $gene_feature here not $l1_feature
|
Thank you for your PR, nevertheless it requires some thoughts to be more generic. |
|
I have addressed the issue in #384, the change is available in AGAT v1.2.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove inappropriate tags while create L2 or L1 feature frome low level feature