Conversation
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #458 +/- ##
==========================================
- Coverage 39.60% 39.39% -0.22%
==========================================
Files 11 11
Lines 2030 2036 +6
==========================================
- Hits 804 802 -2
- Misses 1109 1117 +8
Partials 117 117
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jbygdell
left a comment
There was a problem hiding this comment.
There shuld be no IFs here, the config must be set before any action i.e. sda-cli -config cli.conf ACTION -FLAGS should be the only functioning command.
Config can be as a file or as ENV flags.
Usage for all commands needs to be updated to match the new setup.
MalinAhlberg
left a comment
There was a problem hiding this comment.
Good work, @pahatz! Works well as far as I can tell!
I agree that it is a bit confusing that you can provide two configs, though... unless there's a use case I'm missing, it's probably cleaner to only allow one.
The README also needs some updates (apart from the Usage sections in the go files, that Jocke mentioned).
|
I changed the behavior to work only for the config to be provided before the command. |
cdf06cf to
14cbb58
Compare
14cbb58 to
072234b
Compare
Co-authored-by: Joakim Bygdell <[email protected]>
1d3f898 to
4b57b91
Compare
nanjiangshu
left a comment
There was a problem hiding this comment.
I have just added a comment regarding path concatenation, otherwise, it looks great!
nanjiangshu
left a comment
There was a problem hiding this comment.
Looks good to me. It's weird that the integration test failed even after I reran it. Maybe a rebase to the main will fix the problem.
|
v0.3.158 is the latest released version |
Co-authored-by: Joakim Bygdell <[email protected]>
42d0763 to
d5fb340
Compare
d5fb340 to
db9cd50
Compare
Related issue(s) and PR(s)
This PR closes #442 .
Description
The user should be able to provide the config file location argument ONLY before the subcommand of the cli.
How to test
For test coverage, some of the existing tests have been altered to follow the new allowed order of providing the config, i.e. before the subcommand.
To manually test, one should test individually the cli commands that are affected. Those are the ones that are using the config as an argument(upload, list htsget, download).