Merge pull request #377 from NCAR/get_close_caching_inout

fix: intent(inout) for close_X_dist and close_X_ind

CHANGELOG.rst

@@ -22,9 +22,11 @@ individual files.
 
 The changes are now listed with the most recent at the top.
 
-**July 21 2022 :: Bug-fix for DART_LAB rank histograms. Tag: v10.0.4**
+**July 21 2022 :: Bug-fixes for DART_LAB rank histograms and get_close caching. Tag: v10.0.4**
 
 - Fixes DART_LAB prior and posterior rank histogram calculation.
+- Fix for intent(inout) for get_close_X_caching routines.
+- Obsolete GitHub workflow removed.
 
 **July 14 2022 :: Performance improvement - removal of redundant caching. Tag: v10.0.3**
 

assimilation_code/modules/assimilation/assim_tools_mod.f90

@@ -2565,8 +2565,9 @@ subroutine get_close_obs_cached(gc_obs, base_obs_loc, base_obs_type, &
 type(get_close_type),          intent(in)  :: gc_obs
 type(location_type),           intent(inout) :: base_obs_loc, my_obs_loc(:)
 integer,                       intent(in)  :: base_obs_type, my_obs_kind(:), my_obs_type(:)
-integer,                       intent(out) :: num_close_obs, close_obs_ind(:)
-real(r8),                      intent(out) :: close_obs_dist(:)
+integer,                       intent(out) :: num_close_obs
+integer,                       intent(inout) :: close_obs_ind(:)
+real(r8),                      intent(inout) :: close_obs_dist(:)
 type(ensemble_type),           intent(in)  :: ens_handle
 type(location_type), intent(inout) :: last_base_obs_loc
 integer, intent(inout) :: last_num_close_obs
@@ -2607,8 +2608,9 @@ subroutine get_close_state_cached(gc_state, base_obs_loc, base_obs_type, &
 type(location_type),           intent(inout) :: base_obs_loc, my_state_loc(:)
 integer,                       intent(in)    :: base_obs_type, my_state_kind(:)
 integer(i8),                   intent(in)    :: my_state_indx(:)
-integer,                       intent(out)   :: num_close_states, close_state_ind(:)
-real(r8),                      intent(out)   :: close_state_dist(:)
+integer,                       intent(out)   :: num_close_states
+integer,                       intent(inout) :: close_state_ind(:)
+real(r8),                      intent(inout) :: close_state_dist(:)
 type(ensemble_type),           intent(in)    :: ens_handle
 type(location_type), intent(inout) :: last_base_states_loc
 integer, intent(inout) :: last_num_close_states