Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add quickbuild_tests to developer_tests #575

Closed
wants to merge 2 commits into from

Conversation

ann-norcio
Copy link
Contributor

@ann-norcio ann-norcio commented Nov 8, 2023

Description:

Add quickbuild_tests.sh to run all quickbuilds for specific compilers. (v2 of current build_everything script)

Fixes issue

N/A

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Documentation changes needed?

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.

Tests

Ran individual pass/fail tests for random models & compilers on Derecho

Checklist for merging

  • Updated changelog entry
  • Documentation updated
  • Update conf.py

Checklist for release

  • Merge into main
  • Create release from the main branch with appropriate tag
  • Delete feature-branch

Testing Datasets

  • Dataset needed for testing available upon request
  • Dataset download instructions included
  • No dataset needed

@hkershaw-brown
Copy link
Member

Hi @ann-norcio this is looking good

  • module load for each compiler. - can you do this in the single script or do you need to run quickdbuild_tests.sh for each compiler?
  • total time (all compilers, each compiler)
    • How fast can this be?
  • add submission script for derecho (derecho has 128 core per node)

Comment on lines +56 to +57
template_name="mkmf.template.intel.linux"
elif [[ $FC == "gnu" ]]; then
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to setting the template_name, you'll need to load the compiler module

module load gcc for gnu
module load intel for intel
module load nvhpc for nvhpc

@hkershaw-brown
Copy link
Member

Also ifx since ifort is being retired

@hkershaw-brown
Copy link
Member

Libraries on Derecho (rttov 12, 13, hdfeos):
/glade/campaign/cisl/dares/libraries

Add module load for all compiler, mpif08 argument for gnu compiler, testing submission script for Derecho
@mjs2369 mjs2369 self-requested a review December 7, 2023 20:39
@hkershaw-brown
Copy link
Member

Thanks for your work on this Ann, I'm going to move this to a branch on DART so I can get this into production.

Cheers
Helen

@hkershaw-brown
Copy link
Member

@hkershaw-brown hkershaw-brown mentioned this pull request Dec 11, 2023
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants