179 activities change team relationship to manytomany #248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peucastro
requested changes
Oct 25, 2025
| var password: String, | ||
|
|
||
| @ManyToMany(mappedBy = "teamMembers", fetch = FetchType.EAGER) | ||
| // @JsonIdentityReference(alwaysAsId = true) |
Member
There was a problem hiding this comment.
Suggested change
| // @JsonIdentityReference(alwaysAsId = true) |
| joinColumns = [JoinColumn(name = "activity_id")], | ||
| inverseJoinColumns = [JoinColumn(name = "account_id")] | ||
| ) | ||
| @OrderColumn |
Member
There was a problem hiding this comment.
Ideally, both teamMembers in the Activiy model and the hallOfFame in the Project model should be of type MutableSet. This way we won't need the @OrderColumn annotation. This can be a little tricky to do, but it will increase the performance, since it will eliminate these unnecessary index management in the database.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #179
Review checklist