Skip to content

Conversation

@EdwardSafford-NOAA
Copy link
Contributor

Description

If merged, this PR will ensure minmon scripts do not fail silently

If the cpfs calls within the ush/minmon* scripts have been modified to ensure any error code is reported, both in the script log and via error code returned to the calling ex-script.

Resolves #4171

Type of change

  • Bug fix (fixes something broken)
  • New feature (adds functionality)
  • Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

  • Is this change expected to change outputs (e.g. value changes to existing outputs, new files stored in COM, files removed from COM, filename changes, additions/subtractions to archives)? NO
  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO
  • Does this change require an update to any of the following submodules? NO

How has this been tested?

  • Clone and build on ursa
  • Ran canned C96_atm3DVar test, confirmed changes work correctly
  • Modified code to force an error and re-ran; confirmed this produced an error message in the script log file and was also reported as a failed job

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have documented my code, including function, input, and output descriptions
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • This change is covered by an existing CI test or a new one has been added
  • Any new scripts have been added to the .github/CODEOWNERS file with owners
  • I have made corresponding changes to the system documentation if necessary

Modify minmon scripts to ensure any file copy errors are correctly reported.
Small cleanup.
ONe more cleanup.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

vminmon jobs can fail silently

2 participants