Skip to content

Ensure minmon scripts do not fail silently #4308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
EdwardSafford-NOAA wants to merge 5 commits into
base: develop
Choose a base branch
from
+14 −7
Open

Ensure minmon scripts do not fail silently #4308

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2975c80
Ref #4171
EdwardSafford-NOAA Dec 9, 2025
da98e58
Merge branch 'develop' into feature/min-4171
EdwardSafford-NOAA Dec 9, 2025
d4e3b78
Ref #4171
EdwardSafford-NOAA Dec 9, 2025
bf0da03
Ref #4171
EdwardSafford-NOAA Dec 9, 2025
62513d9
Merge branch 'develop' into feature/min-4171
EdwardSafford-NOAA Dec 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions ush/minmon_xtrct_costs.pl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,11 +214,13 @@

if( -e $filename2 ) {
my $newfile2 = "${tankdir}/${filename2}";
system("cpfs $filename2 $newfile2");
system("cpfs $filename2 ${newfile2}") == 0
or die "cpfs failed to copy ${filename2} to ${newfile2} with exit code $?";
}
if( -e $filename3 ) {
my $newfile3 = "${tankdir}/${filename3}";
system("cpfs $filename3 $newfile3");
system("cpfs ${filename3} ${newfile3}") == 0
or die "cpfs failed to copy ${filename3} to ${newfile3} with exit code $?";
}

} # $rc still == 0 after reading gmon_cost.txt
Expand Down
12 changes: 8 additions & 4 deletions ush/minmon_xtrct_gnorms.pl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,8 @@ sub updateGnormData {
print OUTFILE @filearray;
close( OUTFILE );

system("cpfs $outfile $gdfile");
system("cpfs ${outfile} ${gdfile}") == 0
or die "cpfs failed to copy ${outfile} to ${gdfile} with exit code $?";

}

Expand Down Expand Up @@ -419,17 +420,20 @@ sub updateGnormData {
}

if( -e $filename2 ) {
system("cpfs $filename2 ${tankdir}/.");
system("cpfs ${filename2} ${tankdir}/.") == 0
or die "cpfs failed to copy ${filename2} to ${tankdir} with exit code $?";
}

my $gdfile = "gnorm_data.txt";
if( -e $gdfile ) {
system("cpfs $gdfile ${tankdir}/.");
system("cpfs ${gdfile} ${tankdir}/.") == 0
or die "cpfs failed to copy ${gdfile} to ${tankdir} with exit code $?";
}

my $errmsg = "${cdate}.errmsg.txt";
if( -e $errmsg ) {
system("cpfs $errmsg ${tankdir}/.");
system("cpfs ${errmsg} ${tankdir}/.") == 0
or die "cpfs failed to copy ${errmsg} to ${tankdir} with exit code $?";
}

} # $rc still == 0 after reading gmon_gnorm.txt
Expand Down
3 changes: 2 additions & 1 deletion ush/minmon_xtrct_reduct.pl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,8 @@

if( -e $outfile ) {
my $newfile = "${tankdir}/${outfile}";
system("cpfs $outfile $newfile");
system("cpfs ${outfile} ${newfile}") == 0
or die "cpfs failed to copy ${outfile} to ${newfile} with exit code $?";
}

} else { # $infile does not exist
Expand Down