-
Notifications
You must be signed in to change notification settings - Fork 43
add release action to upload generated distribution file #357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
hey @rem1776 Seth's big update went in, so this might pass now after the merge conflict |
I'm missing something, why is this PR needed? |
@mlee03 this was my suggestion inspired by a recent problem. There was a bug introduced to 2024.05.01 (https://github.com/NOAA-GFDL/FRE-NCtools/releases/tag/2024.05.01) that prevented which had the intent of bumping the tag to 2024.05.02, and did update it in Then, when @HansVahlenkamp redeployed FRE-NCtools in the latest SW environment 2025.01, he redeployed the bug. The slight confusion between the repository tag and the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
got it, one more question why was |
Yes I can add that to this pr. The way it works is when a release is created, it triggers a PR to be created that appends the "-dev" in the configure.ac. Then we would just remove it before tagging a release. |
Oh my bad left that in by accident. Needed it before the build changes went through I'll remove it. |
Description
adds an action workflow to trigger when any
<year>.<version>[.<patch>]
tag is created that will create a new release draft and upload the tarfile created bymake dist
. Once the tag is created and the action runs, the release will be a private draft until someone edits it and hits publish. The draft is set to include the same automatically generated release notes github creates.Here's an example from my fork after I published it, with the
make dist
generated tar file:https://github.com/rem1776/FRE-NCtools/releases/tag/2025.14
The uploaded tarfile name will follow whatever version is set in
configure.ac
, regardless of the tag.I used ubuntu package installs in lieu of a custom image since I can't seem to get past errors building the docs with my spack based images.
This is a draft since the CI is failing right now, thats why I have some build changes in here to get it working. I think it just needs seth's next PR merged and then I'll get rid of any changes besides the workflow yaml.
How Has This Been Tested?
CI
Checklist:
make distcheck
passes