Skip to content

add workflow for automatic tag creation #364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 23, 2025
Merged

Conversation

rem1776
Copy link
Contributor

@rem1776 rem1776 commented Jun 3, 2025

Description
adds a workflow that grabs the version number from the configure.ac and creates a new tag for releases. It will be triggered whenever configure.ac is modified but will not overwrite previously created tags. The grep command will match both xxx.xx.xx and xxx.xx style version numbers. End result basically ensures each new version number committed to main will have a corresponding tag.

Since my other PR is triggered by a tag (#357) and creates the release draft, once these both go in we'd have a (almost) fully automated release process. A PR containing a change to the version number would be merged in to main, and then we would just have to wait for the actions to run and manually release the created draft.

This kind of thing has potential for script injections, so I used a fairly strict grep command and called github's api directly (rather than using normal git commands). Hopefully that will mitigate any dangers, but any opinions are appreciated.

How Has This Been Tested?
my forks main branch

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included
  • make distcheck passes

@rem1776 rem1776 requested review from underwoo and ceblanton June 3, 2025 20:55
@ceblanton
Copy link
Contributor

@rem1776 I conflated this with #357 , sorry.. This is the one that might have the -dev in the configure.ac version

@rem1776
Copy link
Contributor Author

rem1776 commented Jun 23, 2025

@ceblanton I added the -dev workflow, do we still want the auto-tagging workflow when the version is modified as well?

Copy link
Contributor

@ceblanton ceblanton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!!

@mlee03 mlee03 self-requested a review June 23, 2025 18:27
@ceblanton
Copy link
Contributor

@rem1776 Yes, we want both, the -dev workflow and the auto-tagging workflow as well, thanks!

@mlee03 mlee03 merged commit 346682f into NOAA-GFDL:main Jun 23, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants