-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Chrono v9.0.0 #59
base: main
Are you sure you want to change the base?
Conversation
@MShabara: about your issue with Chrono v8 it clearly tells that you did not built Chrono with the required Irrlicht components. Did you? About this pull request: the first error says that is looking for ChMathematics, but if you look at my code there is no call to such file. Same for Get_y. |
Hi @dariomangoni, I did build it with Chrono v.8 with the required Irrlicht components, I did it before in Sept. 2023 and it was working fine, I am not sure what changed. About this pull request: I cloned your main repo by mistake, not the pr_chrono9. I tried your pr_chrono9 branch with both Chrono v.9 and Chrono main and I was able to build Hydrochrono with both, your pull request was done in a perfect timing. @dav-og Could you please review this pull request? |
@dariomangoni Thanks for updating the code to Chrono 9.0.0! |
@tridelat I took care of the rebase so there were no permission issues in (force) pushing on my fork. |
Oh I just realized that since it is a pull request you could have pushed it with no permission issues! |
@dariomangoni it looks like it is now the same as my local rebase, so there is no need for me to push on your branch, all good! |
@tridelat I pushed a small additional commit on the |
Hi,
if you are interested these are the changes required to update HydroChrono to Chrono v9.0.0 (released few days ago) regarding both the code and the CMakeLists infrastructure as well.
There are also few other fixes about:
CHRONO_DATA_DIR
definitionAll tests are running fine (tested only on Win though!)