Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Download nf-core/rnaseq from forked repository #302

Merged
merged 5 commits into from
Jan 15, 2025
Merged

Download nf-core/rnaseq from forked repository #302

merged 5 commits into from
Jan 15, 2025

Conversation

Aratz
Copy link
Contributor

@Aratz Aratz commented Jan 9, 2025

This PR introduces the following changes:

  • download nf-core/rnaseq from forked repository https://github.com/NationalGenomicsInfrastructure/nfcore_rnaseq
  • update nf-core/tools to v3.0.2 (3.1.1 is not available on bioconda yet), and nextflow to 24.0.4 (required by nf-core/tools)
  • Update nf-core/ampliseq to 2.12.0 (downloading ampliseq prior to version 2.9.0 fails)

@Aratz Aratz self-assigned this Jan 9, 2025
aanil
aanil approved these changes Jan 9, 2025
View reviewed changes
Copy link
Member

@aanil aanil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

ssjunnebo
ssjunnebo approved these changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@ssjunnebo ssjunnebo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

MatthiasZepper
MatthiasZepper approved these changes Jan 10, 2025
View reviewed changes
Copy link
Member

@MatthiasZepper MatthiasZepper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments, but since I have also never used Ansible before, I probably do not fully understand how the deployments work.

roles/nf-core/defaults/main.yml Show resolved Hide resolved
roles/nf-core/defaults/main.yml Show resolved Hide resolved
host_vars/deploy/main.yml Show resolved Hide resolved
@Aratz Aratz merged commit ef8ddd9 into NationalGenomicsInfrastructure:bimonthly Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MatthiasZepper MatthiasZepper MatthiasZepper approved these changes

@ssjunnebo ssjunnebo ssjunnebo approved these changes

@aanil aanil aanil approved these changes

@slohse slohse slohse approved these changes

@FranBonath FranBonath Awaiting requested review from FranBonath

Assignees

@Aratz Aratz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Aratz @slohse @MatthiasZepper @aanil @ssjunnebo