Patch reads aggregation EPP #394
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code was run manually for this project overview step with the old file slot configuration. https://ngi-lims-prod.scilifelab.se/clarity/work-details/1146764 |
kedhammar
merged commit 1420d1b
into
NationalGenomicsInfrastructure:master
10 of 11 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the re-writing of this EPP, I decided to keep the weird summary file that nobody knew what it does.
It used to be uploaded to the "AggregationLog" file slot which is now instead used for the standard EPP log. I created a new file slot "AggregationSummary" to move it to.
The issue is that step file slots are not updated until you restart the step, so this will become an issue when running reads aggregation for the hundred or so open project summary steps we have.
This patch will simply skip trying to upload the summary file, if it cannot find its file slot.