Skip to content

Replace Deprecated Methods #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Replace Deprecated Methods #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2f676e0
Replaced deprecated methods
SethSmucker Sep 30, 2024
b6ef757
Merge branch 'main' into task/replace-deprecated-calls
SethSmucker Jan 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion service/src/main/java/org/springframework/cloud/bus/event/AuditReplayRemoteRequestEvent.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ public AuditReplayRemoteRequestEvent(Object source, String originService, Reques
}

public AuditReplayRemoteRequestEvent(Object source, String originService, String destinationService, Request request) {
super(source, originService, destinationService);
super(source, originService, DEFAULT_DESTINATION_FACTORY.getDestination(destinationService));
this.request = request;
}

Expand Down
10 changes: 9 additions & 1 deletion service/src/test/java/datawave/microservice/audit/AuditServiceTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@
import java.io.IOException;
import java.net.URI;
import java.net.URISyntaxException;
import java.nio.file.attribute.FileAttribute;
import java.nio.file.attribute.PosixFilePermission;
import java.util.ArrayList;
import java.util.Arrays;
import java.util.Collection;
Expand All @@ -21,6 +23,7 @@
import java.util.List;
import java.util.Map;
import java.util.Objects;
import java.util.Set;
import java.util.UUID;
import java.util.stream.Collectors;

Expand Down Expand Up @@ -625,7 +628,12 @@ public HealthChecker healthChecker() {
public FileAuditProperties fileAuditProperties() {
FileAuditProperties fileAuditProperties = new FileAuditProperties();
@SuppressWarnings("UnstableApiUsage")
File tempDir = Files.createTempDir();
File tempDir;
try {
tempDir = java.nio.file.Files.createTempDirectory("tempDir").toFile();
} catch (IOException e) {
throw new RuntimeException("Failed to create temporary directory", e);
}
tempDir.deleteOnExit();
fileAuditProperties.setPathUri(tempDir.toURI().toString());
fileAuditProperties.setSubPath("audit");
Expand Down
3 changes: 2 additions & 1 deletion service/src/test/java/datawave/microservice/audit/replay/AuditReplayTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
import java.util.HashMap;
import java.util.List;
import java.util.Map;
import java.util.Objects;
import java.util.concurrent.ConcurrentLinkedDeque;
import java.util.concurrent.TimeUnit;

Expand Down Expand Up @@ -127,7 +128,7 @@ public void setup() throws Exception {

// Copy replay files before each test
File dataDir = new File("src/test/resources/data");
for (File file : dataDir.listFiles())
for (File file : Objects.requireNonNull(dataDir.listFiles()))
Copy link
Collaborator

@ivakegg ivakegg Oct 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What deprecation is this solving?

FileUtils.copyFileToDirectory(file, tempDir);

isHealthy = true;
Expand Down
Loading