test: add infrastructure for RPC testing with real VM #2620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnkushinDaniil
force-pushed
the
daniil/add-vm-test
branch
from
62ea6eb to
f24fd54
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2620 +/- ##
==========================================
+ Coverage 75.14% 75.49% +0.35%
==========================================
Files 140 142 +2
Lines 16815 17036 +221
==========================================
+ Hits 12635 12862 +227
+ Misses 3347 3333 -14
- Partials 833 841 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rodrigo-pino
reviewed
Mar 7, 2025
There was a problem hiding this comment.
I think this PR represents a good approximation of what we want to do. There are only two things which I think shouldn't go in:
- All contract defintion shouldn't depend on Scarb
- All contracts shouldn't be under the same Scarb project umbrella
Now, other minor thing, every compilation artifact which is not a .json or a .sierra should be deleted, unless they hinder the program.
AnkushinDaniil
force-pushed
the
daniil/add-vm-test
branch
from
f24fd54 to
16c8cbc
Compare
AnkushinDaniil
temporarily deployed
to
Development
GitHub Actions
Inactive
AnkushinDaniil
force-pushed
the
daniil/add-vm-test
branch
from
6030f2d to
6a53330
Compare
AnkushinDaniil
temporarily deployed
to
Development
GitHub Actions
Inactive
AnkushinDaniil
force-pushed
the
daniil/add-vm-test
branch
2 times, most recently
from
7493a83 to
5f1a572
Compare
infrmtcs
reviewed
Mar 12, 2025
AnkushinDaniil
temporarily deployed
to
Development
GitHub Actions
Inactive
AnkushinDaniil
temporarily deployed
to
Development
GitHub Actions
Inactive
Comment on lines
+263
to
+265
| maxAddr, ok := new(big.Int).SetString("0x7ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff00", 0) | ||
| require.True(t, ok) |
There was a problem hiding this comment.
Why are you using BigInt here, can the maximum address be bigger than a felt?
There was a problem hiding this comment.
I use it for the Rem method
AnkushinDaniil
temporarily deployed
to
Development
GitHub Actions
Inactive
AnkushinDaniil
force-pushed
the
daniil/add-vm-test
branch
from
1310eb8 to
f79b7ae
Compare
AnkushinDaniil
temporarily deployed
to
Development
GitHub Actions
Inactive
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces infrastructure for testing RPC endpoints using the real VM instead of mocks.
Cairocontracts for testing:test_blockchainfor creating a blockchain with predeployed contracts and preset balancesstarknet_estimateFeeusing real VM execution