Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vm): get upper bound from balance #2634

Open
wants to merge 38 commits into
base: main
Choose a base branch
from
Open

Conversation

AnkushinDaniil
Copy link
Contributor

Important

Review after #2620

Fixes #2519

This PR improves the binary search:

  • Remove original tx
  • Stop execution if account balance is not enough

@AnkushinDaniil AnkushinDaniil added Optimisation New feature or request Refactor rust Pull requests that update Rust code labels Mar 12, 2025
@AnkushinDaniil AnkushinDaniil marked this pull request as draft March 12, 2025 14:12
@AnkushinDaniil AnkushinDaniil marked this pull request as ready for review March 12, 2025 14:24
Copy link

codecov bot commented Mar 12, 2025

Codecov Report

Attention: Patch coverage is 94.27313% with 13 lines in your changes missing coverage. Please review.

Project coverage is 75.59%. Comparing base (93b96c7) to head (b5e586d).

Files with missing lines Patch % Lines
core/test_state.go 55.00% 6 Missing and 3 partials ⚠️
core/state.go 63.63% 0 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2634      +/-   ##
==========================================
+ Coverage   75.14%   75.59%   +0.45%     
==========================================
  Files         140      142       +2     
  Lines       16815    17036     +221     
==========================================
+ Hits        12635    12878     +243     
+ Misses       3347     3320      -27     
- Partials      833      838       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Optimisation New feature or request Refactor rust Pull requests that update Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider getting the upper bound from the balance and not changing the execution flags
1 participant