Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add schema to configs #7493

Merged
merged 8 commits into from
Jan 1, 2025
Merged

Add schema to configs #7493

merged 8 commits into from
Jan 1, 2025

Conversation

flcl42
Copy link
Contributor

@flcl42 flcl42 commented Sep 26, 2024

Changes

  • Add schema to chain configs, so it autocompletes

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Dev experience

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

Out of scope:

  • schema for the chainspecs
  • test configs for correctness according to the schema
  • gh action to update the configs

@flcl42 flcl42 requested a review from rubo September 26, 2024 09:11
@flcl42 flcl42 force-pushed the add-schema-to-configs branch from 0002d61 to 73170da Compare September 26, 2024 09:12
@flcl42 flcl42 marked this pull request as ready for review December 24, 2024 13:05
Copy link
Member

@LukaszRozmej LukaszRozmej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we regenerate schema automatically on some build actions? Maybe the same one that updates pivots?

@flcl42
Copy link
Contributor Author

flcl42 commented Dec 30, 2024

Should we regenerate schema automatically on some build actions? Maybe the same one that updates pivots?

Yeah, a good idea. And we can push it to a repo, change link to absolute github url, so it will become accessible everywhere outside of the solution

@flcl42 flcl42 requested a review from kamilchodola December 30, 2024 13:05
@flcl42 flcl42 merged commit 5c5c86e into master Jan 1, 2025
79 checks passed
@flcl42 flcl42 deleted the add-schema-to-configs branch January 1, 2025 17:14
rjnrohit pushed a commit that referenced this pull request Jan 11, 2025
@rubo
Copy link
Contributor

rubo commented Feb 12, 2025

  • There are build errors because of the PowerShell script
  • Also, the requirement of the PowerShell fails the build for those who don't have it
  • Must have been added to the build-tools.yml to catch such errors

@rubo rubo mentioned this pull request Feb 12, 2025
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants