Skip to content

nodejs_latest: 23.11.0 -> 24.0.0-rc.2 #395431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 17, 2025
Merged

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Apr 2, 2025

Opening things now so it can land before the 25.05 freeze. This removes nodejs_23 (which is now in Maintenance mode, and will be EOL in June, i.e. during 25.05 lifetime) and initiates nodejs_24 (still RC state, 24.0.0 is scheduled for April 22nd).

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: nodejs Node.js is a free, open-source, cross-platform JavaScript runtime environment label Apr 2, 2025
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Apr 7, 2025
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Apr 8, 2025
@aduh95 aduh95 force-pushed the nodejs-24 branch 2 times, most recently from 7914e13 to fba6929 Compare April 8, 2025 16:30
@github-actions github-actions bot added 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Apr 8, 2025
@nix-owners nix-owners bot requested a review from happysalada April 8, 2025 16:37
@aduh95 aduh95 requested a review from Conni2461 April 8, 2025 16:38
@happysalada
Copy link
Contributor

The diff looks good, do you have a link to the changelog ? Im on mobile and i wasnt young enough to figure out how to get it from the github app.
The idea would be just to have a sense of what will break and what we should look out for.

@aduh95
Copy link
Contributor Author

aduh95 commented Apr 8, 2025

There's no changelog per se for the RC versions, there's a WIP one for 24.0.0 in nodejs/node#57609

@winterqt
Copy link
Member

winterqt commented Apr 8, 2025

I'd be fine with landing this with the proper release tag on the 22nd, if they keep their timeline.

@aduh95
Copy link
Contributor Author

aduh95 commented Apr 9, 2025

@winterqt can you clarify what you'd like to see on 25.05 wrt nodejs_latest and nodejs_23 if this PR is not ready in time for the cutoff? I understand you present the best case scenario, but given how tight the timeline is, we should discuss what we want to happen if we leave the happy path (FWIW I think it'd be wiser not to wait and land this as is, it's easy enough to PR the nodejs_24 version bump once the actual 24.0.0 is released, and since this is targeting staging, it should be plenty of time to make the update before even unstable is affected)

@happysalada
Copy link
Contributor

@winterqt what do you think about the proposal to merge this as is and backport the update from rc to stable ?
Since 23 is going to be end of life it makes sense to me.

@github-actions github-actions bot added 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. and removed 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. labels Apr 16, 2025
@happysalada
Copy link
Contributor

@winterqt im sure you know but antoine here is one of the nodejs contributors, it would be nice to give him an answer so we can keep a good relationship with upstream maintainers.

Copy link
Member

@winterqt winterqt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's give it a shot.

(Sorry for the delay.)

@winterqt winterqt merged commit cf236e5 into NixOS:staging Apr 17, 2025
30 of 32 checks passed
@aduh95 aduh95 deleted the nodejs-24 branch April 17, 2025 07:09
@happysalada
Copy link
Contributor

Thank you !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nodejs Node.js is a free, open-source, cross-platform JavaScript runtime environment 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants