-
-
Notifications
You must be signed in to change notification settings - Fork 16.3k
nodejs_latest: 23.11.0 -> 24.0.0-rc.2 #395431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
7914e13
to
fba6929
Compare
The diff looks good, do you have a link to the changelog ? Im on mobile and i wasnt young enough to figure out how to get it from the github app. |
There's no changelog per se for the RC versions, there's a WIP one for 24.0.0 in nodejs/node#57609 |
I'd be fine with landing this with the proper release tag on the 22nd, if they keep their timeline. |
@winterqt can you clarify what you'd like to see on 25.05 wrt |
@winterqt what do you think about the proposal to merge this as is and backport the update from rc to stable ? |
@winterqt im sure you know but antoine here is one of the nodejs contributors, it would be nice to give him an answer so we can keep a good relationship with upstream maintainers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's give it a shot.
(Sorry for the delay.)
Thank you ! |
Opening things now so it can land before the 25.05 freeze. This removes
nodejs_23
(which is now in Maintenance mode, and will be EOL in June, i.e. during 25.05 lifetime) and initiatesnodejs_24
(still RC state, 24.0.0 is scheduled for April 22nd).Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.