-
-
Notifications
You must be signed in to change notification settings - Fork 16.2k
nixos/networking: deprecate networking.extraHosts #413925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd recommend adding an evaluation warning if the option is set, unless too many modules configure it in-tree.
I am seeing 54 usage in Nixpkgs, most of which come from tests. |
This was my first reaction, as well.. I don't know how a user would migrate away from it until they receive notice. But, if the idea is to just add a description notice for in tree development while we wait for in tree migration, that is fine. However, a warning would also drive migration quicker :P |
See NixOS/nixpkgs#413925 Signed-off-by: John Titor <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
8376dbb
to
8544c5f
Compare
8544c5f
to
e686dd5
Compare
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it. @alyssais, what do you think?
This comment was marked as resolved.
This comment was marked as resolved.
I know some anime-styled games alternative-launchers that expect to see some very specific commentaries in /etc/hosts before launching/patching. How are we going to inject those comments without this field that allows abstract values? FIY: This was attempted before #27791 EDIT: This seems more like a problem of vocabulary, misleading to bad usage patterns. Instead, this option should be renamed to something that does not mention “hosts”, like |
This comment was marked as resolved.
This comment was marked as resolved.
|
Signed-off-by: John Titor <[email protected]>
Set it for removal in 26.05 so people are forced to use it. Usage and occurances in tests on Nixpkgs can be migrated in seperate PRs. Signed-off-by: John Titor <[email protected]>
e686dd5
to
8005d49
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that the first commit is "general improvement". And can be merged irrespective of the decision.
Nice work here, would be good to see this re-based and ready for review. |
This kind of is "ready" for review except for the merge conflict part. Note that treewide migration to You are more than welcome to redo that PR. I am not sure on how to move forward/fix that. |
There is already
networking.hosts
that replicates its features with the added benefit of defining multiple hostnames for same IP in a list.Something like;
can be changed to:
All modules in
nixos/modules/**
has been migrated tonetworking.hosts
.Usage and occurances in tests on Nixpkgs can be migrated in seperate PRs.
After a discussion on Matrix with K900, it's best we deprecate this. This option is set to be removed in 26.05. 1 year of deprecation period allows consumers to be migrated safely.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.