Skip to content

feat: reforge nbtModifiers + misc fixes #1939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

lunaynx
Copy link
Contributor

@lunaynx lunaynx commented Jul 29, 2025

Added nbtModifier to every single reforge all reforges where the modifier is different from the lowercased reforge name. Also fixed a couple miscellaneous issues I noticed along the way.

@lunaynx
Copy link
Contributor Author

lunaynx commented Jul 31, 2025

Due to disagreement from the maintainers (which next time I would appreciate as a comment on the pull request or even a ping on Discord rather than having to find out through a snarky response when asking), I have removed "unnecessary" modifiers for any reforges that should be essentially unambigously parseable from their names.

I kept ones where there is a - or space in the reforge name, following the preexisting example of Double-Bit having an explicit nbtModifier, and also added ones where it happens to be equal to the lowercased internalName because otherwise it is ambiguous (since 99% of the time you are parsing from reforgeName instead).

@lunaynx lunaynx changed the title feat: complete nbtModifiers + misc fixes feat: nbtModifiers + misc fixes Jul 31, 2025
@lunaynx lunaynx changed the title feat: nbtModifiers + misc fixes feat: reforge nbtModifiers + misc fixes Jul 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant