[15.0][MIG] account_check_deposit #1301

alexis-via · 2021-12-16T12:34:50Z

No description provided.

* Clean code * Add access rules for account_check_deposit * Change print button name

* [FIX] fix datamodel structure, indeed check_payment_ids should be a m2o. In the view we still keep the widget * [REF] remove useless state cancel, only draft/done is sufficent for now, forbid to delete a done deposit, fix move_line name need to be the equal to the line.ref for the reconciliation * [IMP] improve reconciliation between the check and the check deposit * [FIX] set correctly the date on the move line generated * [FIX] fix reconciliation of check * [IMP] check deposit improve view and add tab for move line generated * [IMP] add total amount and flag to know if the deposit have been reconcile, the best will be to add a workflow * [FIX] fix error when replaying commit * [REF] remove dependency on sale_quick_payment as check can be registred in various way like native voucher * [CLEAN] pep8 cleanup no code change * [REF] clean remove useless code, default value are called during the create * [FIX] fix wrong spelling * [REF] V7 clean up

Works with a single account journal Usability and many other enhancements

… for the payment, one for the deposit), hide unreconcile entry which a link to a deposit

Convert webkit report to qweb

* Move description from __openerp__.py to README.rst * Move files in sub-directories * FIX access rights issue when user was not accounting manager

* create move and move line at the same time * add tests

* Add option to have the counter-part of the deposit move directly to the bank account Use account.config.settings page * Remove data that create a bank journal because it blocks the loading of the chart of accounts when the module is installed at the same time as the chart of account (via dependencies)

…rnal if the offsetting account is the bank account

For avoiding constraint.

Currently translated at 100,0% (61 of 61 strings) Translation: account-financial-tools-11.0/account-financial-tools-11.0-account_check_deposit Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-11-0/account-financial-tools-11-0-account_check_deposit/de/

Updated by Update PO files to match POT (msgmerge) hook in Weblate.

Add print button (feature up-ported from v10) Add option to post moves (feature up-ported from v10) Sequence now takes into account the deposit date Customize the filename of the report Update README with v12 labels

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-financial-tools-13.0/account-financial-tools-13.0-account_check_deposit Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-13-0/account-financial-tools-13-0-account_check_deposit/

…es, so we should always post the move

Update documentation Don't duplicate labels between name of account.move.line and ref of account.move, now that name of account.move.line is not required any more.

Add button "Get All Received Checks" Add default value for journal_id and bank_journal_id when there is only 1 possible value Add hide/show options on lines Improve multi-company handling

Add chatter message when you click on the button to get all checks Add unicity SQL constraint

Currently translated at 84.3% (54 of 64 strings) Translation: account-financial-tools-14.0/account-financial-tools-14.0-account_check_deposit Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-14-0/account-financial-tools-14-0-account_check_deposit/fr/

Currently translated at 100.0% (64 of 64 strings) Translation: account-financial-tools-14.0/account-financial-tools-14.0-account_check_deposit Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-14-0/account-financial-tools-14-0-account_check_deposit/pt/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-financial-tools-14.0/account-financial-tools-14.0-account_check_deposit Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-14-0/account-financial-tools-14-0-account_check_deposit/

Currently translated at 100.0% (90 of 90 strings) Translation: account-financial-tools-14.0/account-financial-tools-14.0-account_check_deposit Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-14-0/account-financial-tools-14-0-account_check_deposit/pt/

Currently translated at 67.7% (61 of 90 strings) Translation: account-financial-tools-14.0/account-financial-tools-14.0-account_check_deposit Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-14-0/account-financial-tools-14-0-account_check_deposit/fr/

Currently translated at 70.0% (63 of 90 strings) Translation: account-financial-tools-14.0/account-financial-tools-14.0-account_check_deposit Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-14-0/account-financial-tools-14-0-account_check_deposit/it/

rafaelbn · 2022-03-23T23:59:53Z

/ocabot migration account_check_deposit

petrus-v

Code review and functional test.

Few details but mainly styling !

petrus-v · 2022-06-09T13:05:19Z

account_check_deposit/models/account_check_deposit.py

+            if deposit.move_id:
+                for line in deposit.move_id.line_ids:
+                    if not company_cur.is_zero(line.debit) and line.reconciled:
+                        reconcile = True


Myself note:

can we have more than one line with debit > 0 ? I don't think so

why use the last line state only ? because we expect to get one record

Should be the same with sugar syntax

Suggested change

if deposit.move_id:

for line in deposit.move_id.line_ids:

if not company_cur.is_zero(line.debit) and line.reconciled:

reconcile = True

if deposit.move_id.line_ids.filtered(lambda line: not company_cur.is_zero(line.debit) and line.reconciled):

reconcile = True

petrus-v · 2022-06-09T13:11:57Z

account_check_deposit/models/account_check_deposit.py

+        if self.journal_id:
+            if self.journal_id.currency_id:
+                self.currency_id = self.journal_id.currency_id
+            else:
+                self.currency_id = self.journal_id.company_id.currency_id


I suppose in v15 we can go straight forwards but won't block for that

Suggested change

if self.journal_id:

if self.journal_id.currency_id:

self.currency_id = self.journal_id.currency_id

else:

self.currency_id = self.journal_id.company_id.currency_id

self.currency_id = self.journal_id.currency_id or self.journal_id.company_id.currency_id

petrus-v · 2022-06-09T14:34:41Z

account_check_deposit/__manifest__.py

+    "summary": "Manage deposit of checks to the bank",
+    "author": "Akretion, Tecnativa, Odoo Community Association (OCA)",
+    "website": "https://github.com/OCA/account-financial-tools",
+    "depends": ["account"],


we should probably add account_usability module in order to be able to access to the accounting sub menu ?

petrus-v · 2022-06-09T14:51:58Z

account_check_deposit/models/account_check_deposit.py

+        string="Number of Checks",
+        tracking=True,
+    )
+    is_reconcile = fields.Boolean(


Not sure to understand the attempt of this field, I can't see any real usage ?

petrus-v · 2022-06-09T14:57:17Z

account_check_deposit/models/account_check_deposit.py

+            if rec.journal_id:
+                for line in rec.journal_id.inbound_payment_method_line_ids:
+                    if (
+                        line.payment_method_id.code == "manual"
+                        and line.payment_account_id
+                    ):
+                        in_hand_check_account_id = line.payment_account_id.id
+                        break
+            rec.in_hand_check_account_id = in_hand_check_account_id


styling suggestion

Suggested change

if rec.journal_id:

for line in rec.journal_id.inbound_payment_method_line_ids:

if (

line.payment_method_id.code == "manual"

and line.payment_account_id

):

in_hand_check_account_id = line.payment_account_id.id

break

rec.in_hand_check_account_id = in_hand_check_account_id

rec.in_hand_check_account_id = rec.journal_id.inbound_payment_method_line_ids.filtered(

lambda line: line.payment_method_id.code == "manual"

).payment_account_id

gregory-moka

Fonctionnal review : works fine

dreispt · 2022-08-10T21:35:03Z

/ocbot merge nobump

gregory-moka · 2022-09-21T06:51:40Z

account_check_deposit/report/report_checkdeposit.xml

+    <template id="report_checkdeposit">
+        <t t-call="web.html_container">
+            <t t-foreach="docs" t-as="o">
+                <t t-call="web.internal_layout">


I'll suggest to use the external layout for this document, as it has to be given to the bank. It's a way to "communicate" to external partner.
<t t-call="web.external_layout">

@alexis-via 😄

You are certainly right ! I'm not a qweb expert, I have more experience on py3o.

victoralmau · 2022-11-23T13:09:03Z

Superseed by #1504

bguillot and others added 30 commits December 7, 2021 10:48

[INIT] init module to manage check deposits

d04d8b6

[FIX] fix remove pdb call

50e14dc

[IMP]account_check_deposit: add the print option webkit

952289b

[FIX+IMP] account_check_deposit: Several things:

c1fe8e6

* Clean code * Add access rules for account_check_deposit * Change print button name

Add support for multi-currency

3b07b36

Works with a single account journal Usability and many other enhancements

[FIX] fix domain, give the posibility to use a different journal (one…

b13e84d

… for the payment, one for the deposit), hide unreconcile entry which a link to a deposit

german translations upto invoice currency

37bd025

[FIX] move translation file in unported folders

1b13e2f

[PORT] start porting account_check_deposit

f861711

Port to v8

589889a

Convert webkit report to qweb

OCA Transbot updated translations from Transifex

d8b020a

[REF] account_check_deposit : Port to new API

115b0ff

* Move description from __openerp__.py to README.rst * Move files in sub-directories * FIX access rights issue when user was not accounting manager

OCA Transbot updated translations from Transifex

665258a

[MIG] account_check_deposit: Migration to 9.0

0850c9f

* create move and move line at the same time * add tests

Fix payment field + automatic reconciliation on validation

34c6f00

OCA Transbot updated translations from Transifex

d123ed1

[FIX+imp] account_check_deposit: no auto-post move + use the bank jou…

64004b7

…rnal if the offsetting account is the bank account

OCA Transbot updated translations from Transifex

1d72d05

[FIX] account_check_deposit: Change company currency in tests by SQL

1b661bd

For avoiding constraint.

[UPD] Update account_check_deposit.pot

16fbd9c

[MIG] account_check_deposit: Migration to 11.0

2ab769e

[UPD] Update account_check_deposit.pot

89e2eb5

[UPD] README.rst

a21f6d2

Update translation files

3600c27

Updated by Update PO files to match POT (msgmerge) hook in Weblate.

[MIG] Account Check Deposit to 12.0

aa4df7c

account_check_deposit: Don't force 'name' of account.move

4133d7f

Add print button (feature up-ported from v10) Add option to post moves (feature up-ported from v10) Sequence now takes into account the deposit date Customize the filename of the report Update README with v12 labels

[UPD] README.rst

61d24c2

oca-transbot and others added 18 commits December 7, 2021 10:48

[MIG] account_check_deposit from v13 to v14

d8e9482

Remove post_move option, because we cannot reconcile non-posted entri…

1f7cd38

…es, so we should always post the move

account_check_deposit: remove configuration parameters from res.company

ad3a344

Update documentation Don't duplicate labels between name of account.move.line and ref of account.move, now that name of account.move.line is not required any more.

account_check_deposit: usability improvements

1453697

Add button "Get All Received Checks" Add default value for journal_id and bank_journal_id when there is only 1 possible value Add hide/show options on lines Improve multi-company handling

account_check_deposit: migrate tests

a417403

account_check_deposit: Add chatter on check deposit

ad49e92

Add chatter message when you click on the button to get all checks Add unicity SQL constraint

[UPD] Update account_check_deposit.pot

9c33e7c

[UPD] README.rst

67bcd65

[UPD] Update account_check_deposit.pot

6a347ec

[MIG] account_check_deposit from v14 to v15

1647e59

rafaelbn added the needs review label Mar 24, 2022

OCA-git-bot added this to the 15.0 milestone Mar 24, 2022

OCA-git-bot mentioned this pull request Mar 24, 2022

Migration to version 15.0 #1253

Open

31 tasks

petrus-v approved these changes Jun 9, 2022

View reviewed changes

gregory-moka approved these changes Aug 9, 2022

View reviewed changes

OCA-git-bot added the approved label Aug 9, 2022

gregory-moka reviewed Sep 21, 2022

View reviewed changes

victoralmau mentioned this pull request Nov 23, 2022

[15.0][MIG] account_check_deposit: Migration to 15.0 #1504

Merged

10 tasks

pedrobaeza closed this Nov 23, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[15.0][MIG] account_check_deposit #1301

[15.0][MIG] account_check_deposit #1301

alexis-via commented Dec 16, 2021

rafaelbn commented Mar 23, 2022

petrus-v left a comment

petrus-v Jun 9, 2022

petrus-v Jun 9, 2022

petrus-v Jun 9, 2022 •

edited

Loading

petrus-v Jun 9, 2022

petrus-v Jun 9, 2022

gregory-moka left a comment

dreispt commented Aug 10, 2022

gregory-moka Sep 21, 2022

gregory-moka Sep 21, 2022

alexis-via Sep 21, 2022

victoralmau commented Nov 23, 2022

[15.0][MIG] account_check_deposit #1301

[15.0][MIG] account_check_deposit #1301

Conversation

alexis-via commented Dec 16, 2021

rafaelbn commented Mar 23, 2022

petrus-v left a comment

Choose a reason for hiding this comment

petrus-v Jun 9, 2022

Choose a reason for hiding this comment

petrus-v Jun 9, 2022

Choose a reason for hiding this comment

petrus-v Jun 9, 2022 • edited Loading

Choose a reason for hiding this comment

petrus-v Jun 9, 2022

Choose a reason for hiding this comment

petrus-v Jun 9, 2022

Choose a reason for hiding this comment

gregory-moka left a comment

Choose a reason for hiding this comment

dreispt commented Aug 10, 2022

gregory-moka Sep 21, 2022

Choose a reason for hiding this comment

gregory-moka Sep 21, 2022

Choose a reason for hiding this comment

alexis-via Sep 21, 2022

Choose a reason for hiding this comment

victoralmau commented Nov 23, 2022

petrus-v Jun 9, 2022 •

edited

Loading