Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0][MIG] account_check_deposit: Migration to 15.0 #1504

Merged
merged 48 commits into from
Nov 23, 2022

Conversation

victoralmau
Copy link
Member

@victoralmau victoralmau commented Nov 23, 2022

Superseed: #1301

Migration to 15.0

Changes done:

Please @pedrobaeza can you review it?

@Tecnativa TT36937

bguillot and others added 30 commits November 23, 2022 12:47
* Clean code
* Add access rules for account_check_deposit
* Change print button name
* [FIX] fix datamodel structure, indeed check_payment_ids should be a m2o. In the view we still keep the widget
* [REF] remove useless state cancel, only draft/done is sufficent for now, forbid to delete a done deposit, fix move_line name need to be the equal to the line.ref for the reconciliation
* [IMP] improve reconciliation between the check and the check deposit
* [FIX] set correctly the date on the move line generated
* [FIX] fix reconciliation of check
* [IMP] check deposit improve view and add tab for move line generated
* [IMP] add total amount and flag to know if the deposit have been reconcile, the best will be to add a workflow
* [FIX] fix error when replaying commit
* [REF] remove dependency on sale_quick_payment as check can be registred in various way like native voucher
* [CLEAN] pep8 cleanup no code change
* [REF] clean remove useless code, default value are called during the create
* [FIX] fix wrong spelling
* [REF] V7 clean up
Works with a single account journal
Usability and many other enhancements
… for the payment, one for the deposit), hide unreconcile entry which a link to a deposit
Convert webkit report to qweb
* Move description from __openerp__.py to README.rst
* Move files in sub-directories
* FIX access rights issue when user was not accounting manager

OCA Transbot updated translations from Transifex
* create move and move line at the same time
* add tests
* Add option to have the counter-part of the deposit move directly to the bank account
  Use account.config.settings page
* Remove data that create a bank journal because it blocks the loading of the chart of accounts when
  the module is installed at the same time as the chart of account (via dependencies)

OCA Transbot updated translations from Transifex
…rnal if the offsetting account is the bank account

OCA Transbot updated translations from Transifex
For avoiding constraint.

[UPD] Update account_check_deposit.pot
[UPD] Update account_check_deposit.pot

[UPD] README.rst
Currently translated at 100,0% (61 of 61 strings)

Translation: account-financial-tools-11.0/account-financial-tools-11.0-account_check_deposit
Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-11-0/account-financial-tools-11-0-account_check_deposit/de/

Update translation files

Updated by Update PO files to match POT (msgmerge) hook in Weblate.
Add print button (feature up-ported from v10)
Add option to post moves (feature up-ported from v10)
Sequence now takes into account the deposit date
Customize the filename of the report
Update README with v12 labels

[UPD] README.rst

[UPD] Update account_check_deposit.pot

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: account-financial-tools-12.0/account-financial-tools-12.0-account_check_deposit
Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-12-0/account-financial-tools-12-0-account_check_deposit/

[UPD] README.rst
Currently translated at 100.0% (63 of 63 strings)

Translation: account-financial-tools-12.0/account-financial-tools-12.0-account_check_deposit
Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-12-0/account-financial-tools-12-0-account_check_deposit/pt/
Currently translated at 100.0% (63 of 63 strings)

Translation: account-financial-tools-12.0/account-financial-tools-12.0-account_check_deposit
Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-12-0/account-financial-tools-12-0-account_check_deposit/pt/
Currently translated at 100.0% (63 of 63 strings)

Translation: account-financial-tools-12.0/account-financial-tools-12.0-account_check_deposit
Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-12-0/account-financial-tools-12-0-account_check_deposit/pt/
Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: account-financial-tools-13.0/account-financial-tools-13.0-account_check_deposit
Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-13-0/account-financial-tools-13-0-account_check_deposit/

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: account-financial-tools-13.0/account-financial-tools-13.0-account_check_deposit
Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-13-0/account-financial-tools-13-0-account_check_deposit/
alexis-via and others added 14 commits November 23, 2022 12:52
Add chatter message when you click on the button to get all checks
Add unicity SQL constraint

[UPD] Update account_check_deposit.pot

[UPD] README.rst
Currently translated at 84.3% (54 of 64 strings)

Translation: account-financial-tools-14.0/account-financial-tools-14.0-account_check_deposit
Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-14-0/account-financial-tools-14-0-account_check_deposit/fr/
Currently translated at 100.0% (64 of 64 strings)

Translation: account-financial-tools-14.0/account-financial-tools-14.0-account_check_deposit
Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-14-0/account-financial-tools-14-0-account_check_deposit/pt/

[UPD] Update account_check_deposit.pot

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: account-financial-tools-14.0/account-financial-tools-14.0-account_check_deposit
Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-14-0/account-financial-tools-14-0-account_check_deposit/
Currently translated at 100.0% (90 of 90 strings)

Translation: account-financial-tools-14.0/account-financial-tools-14.0-account_check_deposit
Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-14-0/account-financial-tools-14-0-account_check_deposit/pt/
Currently translated at 67.7% (61 of 90 strings)

Translation: account-financial-tools-14.0/account-financial-tools-14.0-account_check_deposit
Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-14-0/account-financial-tools-14-0-account_check_deposit/fr/
Currently translated at 70.0% (63 of 90 strings)

Translation: account-financial-tools-14.0/account-financial-tools-14.0-account_check_deposit
Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-14-0/account-financial-tools-14-0-account_check_deposit/it/
account_check_deposit 14.0.1.0.1

[IMP] update dotfiles
Currently translated at 72.2% (65 of 90 strings)

Translation: account-financial-tools-14.0/account-financial-tools-14.0-account_check_deposit
Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-14-0/account-financial-tools-14-0-account_check_deposit/it/
Currently translated at 74.4% (67 of 90 strings)

Translation: account-financial-tools-14.0/account-financial-tools-14.0-account_check_deposit
Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-14-0/account-financial-tools-14-0-account_check_deposit/it/
Currently translated at 17.7% (16 of 90 strings)

Translation: account-financial-tools-14.0/account-financial-tools-14.0-account_check_deposit
Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-14-0/account-financial-tools-14-0-account_check_deposit/pt_BR/
@victoralmau victoralmau marked this pull request as ready for review November 23, 2022 13:08
@pedrobaeza
Copy link
Member

/ocabot migration account_check_deposit

@OCA-git-bot OCA-git-bot added this to the 15.0 milestone Nov 23, 2022
@OCA-git-bot OCA-git-bot mentioned this pull request Nov 23, 2022
31 tasks
@OCA-git-bot
Copy link
Contributor

The migration issue (#1253) has been updated to reference the current pull request.
however, a previous pull request was referenced : #1301.
Perhaps you should check that there is no duplicate work.
CC : @alexis-via

@pedrobaeza
Copy link
Member

Merging after the way on the other PR

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 15.0-ocabot-merge-pr-1504-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit ec6e033 into OCA:15.0 Nov 23, 2022
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at efb8610. Thanks a lot for contributing to OCA. ❤️

@alexis-via
Copy link
Contributor

FYI, the goal of the field is_reconciled is to be able to know if the check deposit has arrived on your bank account (the debit line of the check deposit move is reconciled with the bank move).

@pedrobaeza pedrobaeza deleted the 15.0-mig-account_check_deposit branch December 3, 2022 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.