[17.0][MIG] account_banking_pain_base: Migration to 17.0 #1231

trisdoan · 2024-03-06T09:30:40Z

No description provided.

HaraldPanten

LGTM. Functional review.

manuelregidor · 2024-03-07T11:46:41Z

account_banking_pain_base/models/account_payment_order.py

            ("DEBT", "Borne by Debtor"),
        ],
        default="SLEV",
-        readonly=True,


Don't you think it would be more convenient to leave this line? It should always be readonly except when the state is draft or open, which is defined in the view. In my opinion, it would be better to keep the field as readonly in the logic layer, as editting the view manually can be easily done.

Hi @manuelregidor, thank you for your in-depth review.

readonly=True prevents users from importing. That's why I removed it

Then put the readonly in view

Anyway, it's the first time I hear about this limitation. Is it something new in 17.0?

@trisdoan @pedrobaeza yes, it's new in v17

Then as said, you should limit it in the view.

manuelregidor · 2024-03-07T11:47:09Z

account_banking_pain_base/models/account_payment_order.py

        "debtor.",
    )
    batch_booking = fields.Boolean(
-        readonly=True,


Same as charge_bearer field.

pedrobaeza · 2024-03-11T07:23:36Z

/ocabot migration account_banking_pain_base

HaraldPanten · 2024-03-14T14:53:57Z

Hi @trisdoan will you continue with the suggested changes?

trisdoan · 2024-03-15T03:46:22Z

Hi @HaraldPanten and @pedrobaeza , please correct me if I understood you wrong

I think I applied the read-only for batch_booking and charge_bearer in the view

  <field name="batch_booking" readonly="state not in ['draft','open']" />
  <field
      name="charge_bearer"
      invisible="sepa"
      readonly="state not in ['draft','open']"
  />

pedrobaeza · 2024-03-15T07:08:22Z

Yes, that's it.

angelmoya

👍

pedrobaeza · 2024-03-22T09:02:47Z

@trisdoan are you going to perform the latest change we commented?

trisdoan · 2024-03-22T14:42:40Z

Hi @pedrobaeza, sorry I am a bit confused now 😕 I might miss something.

are you going to perform the latest change we commented?

I assume you mean: read-only for batch_booking and charge_bearer in the view ? If yes, I already did that

Or not, can you help to show me what I miss, I am willing to adjust it

pedrobaeza

Sorry, that's it!

/ocabot merge nobump

OCA-git-bot · 2024-03-22T14:55:48Z

On my way to merge this fine PR!
Prepared branch 17.0-ocabot-merge-pr-1231-by-pedrobaeza-bump-nobump, awaiting test results.

Signed-off-by pedrobaeza

OCA-git-bot · 2024-03-22T14:57:09Z

@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 17.0-ocabot-merge-pr-1231-by-pedrobaeza-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

pedrobaeza · 2024-03-22T15:01:15Z

@trisdoan please rebase and check pre-commit errors:

account_banking_pain_base/models/account_payment_order.py:63:89: E501 Line too long (175 > 88)
account_banking_pain_base/models/account_payment_order.py:229:89: E501 Line too long (92 > 88)

OCA-git-bot · 2024-03-22T15:01:16Z

@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 17.0-ocabot-merge-pr-1231-by-pedrobaeza-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

…13-11-21: - add module account_banking_pain_base - add support for initiating party identification, priority and structured remittance info in XML file - the requested execution date now uses the fields date_prefered and date_scheduled (the field of the wizard has been removed) - the 'convert to ascii' feature is now an option of the payment mode (enabled by default) - set 'communication' field of payment.line to 140 chars and hide field 'communication2' - Code factoring for SCT and SDD - Add support for direct debit migration from national format to SEPA - Source : Standard-XML-SDD-Initiation-v3-EN by Febelfin - Add group in order to mask the fields for "Original Mandate Indentification" for users in countries that don't required it. - Add tracking on important fields of the mandate. - Better form view on company. - Update constraint on mandate following my devs on "Original Mandate Identification". - Add support for Party Identifier for Belgium. Can be easily extended for other countries. - Mutualize more code between SCT and SDD.

* Make it easier to extend structured communication types. * Use new style to make selection extendable. * Help text for bank and BIC fields. Courtesy of Alexis de Lattre. * Do not use InstrPrty for Direct Debit.

…f payment order

…(migration script included)

Currently translated at 64.7% (110 of 170 strings) Translation: bank-payment-16.0/bank-payment-16.0-account_banking_pain_base Translate-URL: https://translation.odoo-community.org/projects/bank-payment-16-0/bank-payment-16-0-account_banking_pain_base/es/

Currently translated at 98.8% (168 of 170 strings) Translation: bank-payment-16.0/bank-payment-16.0-account_banking_pain_base Translate-URL: https://translation.odoo-community.org/projects/bank-payment-16-0/bank-payment-16-0-account_banking_pain_base/es/

Currently translated at 60.0% (102 of 170 strings) Translation: bank-payment-16.0/bank-payment-16.0-account_banking_pain_base Translate-URL: https://translation.odoo-community.org/projects/bank-payment-16-0/bank-payment-16-0-account_banking_pain_base/hr/

Currently translated at 100.0% (170 of 170 strings) Translation: bank-payment-16.0/bank-payment-16.0-account_banking_pain_base Translate-URL: https://translation.odoo-community.org/projects/bank-payment-16-0/bank-payment-16-0-account_banking_pain_base/fr/

Currently translated at 31.1% (53 of 170 strings) Translation: bank-payment-16.0/bank-payment-16.0-account_banking_pain_base Translate-URL: https://translation.odoo-community.org/projects/bank-payment-16-0/bank-payment-16-0-account_banking_pain_base/it/

Currently translated at 100.0% (170 of 170 strings) Translation: bank-payment-16.0/bank-payment-16.0-account_banking_pain_base Translate-URL: https://translation.odoo-community.org/projects/bank-payment-16-0/bank-payment-16-0-account_banking_pain_base/es/

Currently translated at 31.1% (53 of 170 strings) Translation: bank-payment-16.0/bank-payment-16.0-account_banking_pain_base Translate-URL: https://translation.odoo-community.org/projects/bank-payment-16-0/bank-payment-16-0-account_banking_pain_base/it/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: bank-payment-16.0/bank-payment-16.0-account_banking_pain_base Translate-URL: https://translation.odoo-community.org/projects/bank-payment-16-0/bank-payment-16-0-account_banking_pain_base/

The field 'sepa' on account.payment.order is only display for SEPA payment methods. If the option "show warning if not SEPA" is enabled on the payment method, a warning banner is now displayed on payment orders with a SEPA payment method which are not SEPA.

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: bank-payment-16.0/bank-payment-16.0-account_banking_pain_base Translate-URL: https://translation.odoo-community.org/projects/bank-payment-16-0/bank-payment-16-0-account_banking_pain_base/

Currently translated at 100.0% (175 of 175 strings) Translation: bank-payment-16.0/bank-payment-16.0-account_banking_pain_base Translate-URL: https://translation.odoo-community.org/projects/bank-payment-16-0/bank-payment-16-0-account_banking_pain_base/es/

Currently translated at 30.2% (53 of 175 strings) Translation: bank-payment-16.0/bank-payment-16.0-account_banking_pain_base Translate-URL: https://translation.odoo-community.org/projects/bank-payment-16-0/bank-payment-16-0-account_banking_pain_base/it/

Currently translated at 30.8% (54 of 175 strings) Translation: bank-payment-16.0/bank-payment-16.0-account_banking_pain_base Translate-URL: https://translation.odoo-community.org/projects/bank-payment-16-0/bank-payment-16-0-account_banking_pain_base/it/

trisdoan · 2024-03-22T15:50:31Z

ping @pedrobaeza, it's done

pedrobaeza · 2024-03-22T16:53:50Z

/ocabot merge nobump

OCA-git-bot · 2024-03-22T16:53:56Z

What a great day to merge this nice PR. Let's do it!
Prepared branch 17.0-ocabot-merge-pr-1231-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot · 2024-03-22T16:59:38Z

Congratulations, your PR was merged at 09650c3. Thanks a lot for contributing to OCA. ❤️

This was referenced Mar 6, 2024

[17.0][MIG] account_banking_sepa_credit_transfer: Migration to 17.0 #1229

Closed

[17.0][MIG] account_banking_sepa_credit_transfer: Migration to 17.0 #1236

Merged

Migration to version 17.0 #1173

Open

HaraldPanten approved these changes Mar 7, 2024

View reviewed changes

manuelregidor reviewed Mar 7, 2024

View reviewed changes

OCA-git-bot added this to the 17.0 milestone Mar 11, 2024

JasminSForgeFlow mentioned this pull request Mar 18, 2024

[17.0][MIG] account_banking_sepa_direct_debit #1239

Merged

angelmoya approved these changes Mar 20, 2024

View reviewed changes

OCA-git-bot added the approved label Mar 20, 2024

pedrobaeza approved these changes Mar 22, 2024

View reviewed changes

OCA-git-bot added a commit that referenced this pull request Mar 22, 2024

Merge PR #1231 into 17.0

66a5fe2

Signed-off-by pedrobaeza

OCA-git-bot added the bot is merging ⏳ label Mar 22, 2024

OCA-git-bot removed the bot is merging ⏳ label Mar 22, 2024

Alexis de Lattre and others added 7 commits March 22, 2024 22:35

[FIX] account_banking_pain_base: support party identifier for Spain

0410f0e

Launchpad automatic translations update.

88e9a3f

[MIG] account_banking_pain_base: Migration to 8.0

5ce8c4e

[IMP] account_banking_pain_base: Several things:

22ad288

* Make it easier to extend structured communication types. * Use new style to make selection extendable. * Help text for bank and BIC fields. Courtesy of Alexis de Lattre. * Do not use InstrPrty for Direct Debit.

Use attachments instead of creating a specific object for each kind o…

2404110

…f payment order

Fix bug OCA#111 New field initiating_party_identifier on res.company …

0f9920a

…(migration script included)

pedrobaeza and others added 21 commits March 22, 2024 22:35

[MIG] account_banking_pain_base: Migration to 16.0

9860421

[BOT] post-merge updates

a26d265

[IMP] account_banking_pain_base: pre-commit auto fixes

47edbf1

[MIG] account_banking_pain_base: Migration to 17.0

6294587

trisdoan force-pushed the 17.0-mig-account_banking_pain_base branch from e5267b7 to 6294587 Compare March 22, 2024 15:48

OCA-git-bot added the bot is merging ⏳ label Mar 22, 2024

OCA-git-bot merged commit 7948ccb into OCA:17.0 Mar 22, 2024

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Mar 22, 2024

Uh oh!

[17.0][MIG] account_banking_pain_base: Migration to 17.0 #1231

[17.0][MIG] account_banking_pain_base: Migration to 17.0 #1231

Uh oh!

Conversation

trisdoan commented Mar 6, 2024

Uh oh!

HaraldPanten left a comment

Choose a reason for hiding this comment

Uh oh!

manuelregidor Mar 7, 2024

Choose a reason for hiding this comment

Uh oh!

trisdoan Mar 9, 2024

Choose a reason for hiding this comment

Uh oh!

pedrobaeza Mar 9, 2024

Choose a reason for hiding this comment

Uh oh!

pedrobaeza Mar 9, 2024

Choose a reason for hiding this comment

Uh oh!

manuelregidor Mar 11, 2024

Choose a reason for hiding this comment

Uh oh!

pedrobaeza Mar 11, 2024

Choose a reason for hiding this comment

Uh oh!

manuelregidor Mar 7, 2024

Choose a reason for hiding this comment

Uh oh!

pedrobaeza commented Mar 11, 2024

Uh oh!

HaraldPanten commented Mar 14, 2024

Uh oh!

trisdoan commented Mar 15, 2024

Uh oh!

pedrobaeza commented Mar 15, 2024

Uh oh!

angelmoya left a comment

Choose a reason for hiding this comment

Uh oh!

pedrobaeza commented Mar 22, 2024

Uh oh!

trisdoan commented Mar 22, 2024

Uh oh!

pedrobaeza left a comment

Choose a reason for hiding this comment

Uh oh!

OCA-git-bot commented Mar 22, 2024

Uh oh!

OCA-git-bot commented Mar 22, 2024

Uh oh!

pedrobaeza commented Mar 22, 2024

Uh oh!

OCA-git-bot commented Mar 22, 2024

Uh oh!

trisdoan commented Mar 22, 2024

Uh oh!

pedrobaeza commented Mar 22, 2024

Uh oh!

OCA-git-bot commented Mar 22, 2024

Uh oh!

OCA-git-bot commented Mar 22, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

40 participants