Skip to content

[MIG] account_invoice_select_for_payment: Migration to 14.0 #757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 3, 2021
Merged

[MIG] account_invoice_select_for_payment: Migration to 14.0 #757

merged 4 commits into from
Aug 3, 2021

Conversation

@phuctranfxvn
Copy link
Contributor

Hello,

This module has been migrated from this pending MR: #716

Thanks

@phuctranfxvn phuctranfxvn mentioned this pull request Dec 21, 2020
Closed
11 tasks
@max3903 max3903 added this to the 14.0 milestone Jan 28, 2021
TDu
TDu approved these changes Jun 29, 2021
View reviewed changes
Copy link
Member

@TDu TDu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, thank you

@TDu
Copy link
Member

TDu commented Jun 29, 2021

Actually it seems that the module in 13.0 has been changed since the migration, could you check ?

@hailangvn hailangvn force-pushed the 14.0-mig-account_invoice_select_for_payment branch from d916972 to 9e24ab4 Compare July 5, 2021 03:52
@hailangvn
Copy link

Actually it seems that the module in 13.0 has been changed since the migration, could you check ?

Thanks TDu for your review. We updated PR with 2 applicable commits. Please help to review again. Thank you in advance.

@TDu
Copy link
Member

TDu commented Jul 6, 2021

The main commit is still does not look the same than the 13.0 version commit 2b3fe95#diff-bf45ec33fc02aa24c3431eb4c9ca15426896edd9b88c7127b5a556d6728c447e

@hailangvn Could you check again

@hailangvn hailangvn force-pushed the 14.0-mig-account_invoice_select_for_payment branch 2 times, most recently from 0eecd0f to c2744e1 Compare July 6, 2021 12:59
@hailangvn
Copy link

Thanks @TDu for the specific commit. This PR has been updated accordingly.

gurneyalex and others added 4 commits July 7, 2021 03:45
@gurneyalex @hailangvn
ADD 13.0 account_invoice_select_for_payment
b9b41e0 
This module allows to mark invoices as "selected for payment". This can be done
in the list view of invoices using a button in the first column of the view
which shows the selection status. This selection persists until a payment is
registered.
@phuctranfxvn @hailangvn
[MIG] account_invoice_select_for_payment: Migration to 14.0
f36d969
@oca-travis @hailangvn
[UPD] Update account_invoice_select_for_payment.pot
483a65a
@OCA-git-bot @hailangvn
[ADD] icon.png
b36f54d
@hailangvn hailangvn force-pushed the 14.0-mig-account_invoice_select_for_payment branch from c2744e1 to b36f54d Compare July 6, 2021 20:52
@simahawk
Copy link

simahawk commented Aug 3, 2021

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 14.0-ocabot-merge-pr-757-by-simahawk-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit f8762a1 into OCA:14.0 Aug 3, 2021
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 1d6700f. Thanks a lot for contributing to OCA. ❤️

@hailangvn hailangvn deleted the 14.0-mig-account_invoice_select_for_payment branch September 16, 2021 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@TDu TDu TDu approved these changes

@sebalix sebalix sebalix approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved merged 🎉

Projects

None yet

Milestone

14.0

Development

Successfully merging this pull request may close these issues.

9 participants

@phuctranfxvn @TDu @hailangvn @simahawk @OCA-git-bot @sebalix @max3903 @gurneyalex @oca-travis