Skip to content

Conversation

@alexis-via
Copy link
Contributor

No description provided.

Alexis de Lattre and others added 30 commits December 24, 2020 10:23
- account_payment_partner
- account_payment_sale
- account_payment_sale_stock
- account_payment_purchase

Filter the selection of invoices per payment type.
Add active field on payment.mode and payment.mode.type.
Add menu entry for Payment Types.
* Migration and enhancement of all modules involved in SEPA
* Remove duplicated files
* Check if payment mode is set in the propagation
* Clean files
* account_payment_sale_stock: Split for removing stock dependency on sale
* Remove old translations templates
* Reorder on folder structure
* Translation template files
* Translations to spanish
* Use sale_ok and purchase_ok instead of tweaking payment type
* Add sale_ok and purchase_ok filters in partner/sale/purchase form views
* Use widget=selection for payment_mode_id fields
* Update demo data
Port almost all modules to v10

* Update to EPC Rulebook v9.2 that start to apply on 2016-11-20 (bug OCA#300)
Currently translated at 100,0% (4 of 4 strings)

Translation: bank-payment-11.0/bank-payment-11.0-account_payment_sale
Translate-URL: https://translation.odoo-community.org/projects/bank-payment-11-0/bank-payment-11-0-account_payment_sale/es/
Currently translated at 100.0% (4 of 4 strings)

Translation: bank-payment-12.0/bank-payment-12.0-account_payment_sale
Translate-URL: https://translation.odoo-community.org/projects/bank-payment-12-0/bank-payment-12-0-account_payment_sale/pt_BR/
Currently translated at 100.0% (4 of 4 strings)

Translation: bank-payment-12.0/bank-payment-12.0-account_payment_sale
Translate-URL: https://translation.odoo-community.org/projects/bank-payment-12-0/bank-payment-12-0-account_payment_sale/zh_CN/
…d from a call to sale.action_invoice_create

Into the normal process of the invoice creation from a sale order by odoo, the onchange_partner is called. In some case, this call will reset the specific payment_mode and/or partner_bank_id set on the sale_order.
To fix this issue, we must override the _finalize_invoices method, take a snapshot of these values before the call to super and restore these values if these are changed.
fixes OCA#536
Currently translated at 100.0% (4 of 4 strings)

Translation: bank-payment-12.0/bank-payment-12.0-account_payment_sale
Translate-URL: https://translation.odoo-community.org/projects/bank-payment-12-0/bank-payment-12-0-account_payment_sale/ca/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: bank-payment-13.0/bank-payment-13.0-account_payment_sale
Translate-URL: https://translation.odoo-community.org/projects/bank-payment-13-0/bank-payment-13-0-account_payment_sale/
ibuioli and others added 6 commits December 24, 2020 10:23
Currently translated at 100.0% (5 of 5 strings)

Translation: bank-payment-13.0/bank-payment-13.0-account_payment_sale
Translate-URL: https://translation.odoo-community.org/projects/bank-payment-13-0/bank-payment-13-0-account_payment_sale/es_AR/
Currently translated at 100.0% (5 of 5 strings)

Translation: bank-payment-13.0/bank-payment-13.0-account_payment_sale
Translate-URL: https://translation.odoo-community.org/projects/bank-payment-13-0/bank-payment-13-0-account_payment_sale/pt_BR/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: bank-payment-13.0/bank-payment-13.0-account_payment_sale
Translate-URL: https://translation.odoo-community.org/projects/bank-payment-13-0/bank-payment-13-0-account_payment_sale/
Currently translated at 100.0% (5 of 5 strings)

Translation: bank-payment-13.0/bank-payment-13.0-account_payment_sale
Translate-URL: https://translation.odoo-community.org/projects/bank-payment-13-0/bank-payment-13-0-account_payment_sale/es_AR/
…irect_debit

Steps to reproduce the problem:

- Set a payment mode with fixed journal and set the journal with bank account A.
- Create a sales order and put bank account B.
- Create invoice.
- Bank account in invoice is A instead of B.
@pedrobaeza pedrobaeza added this to the 14.0 milestone Dec 24, 2020
@pedrobaeza pedrobaeza mentioned this pull request Jan 24, 2021
11 tasks
@pedrobaeza
Copy link
Member

Any news about this? Check #796 for an additional change

@alexis-via
Copy link
Contributor Author

@pedrobaeza I already added check_company=True on the field payment_mode_id in this PR !

Copy link

@didierdonze didierdonze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional test ok!

@pedrobaeza
Copy link
Member

Forget my last remarks:

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 14.0-ocabot-merge-pr-759-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit fdcf5ac into OCA:14.0 Apr 2, 2021
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 73454b6. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.