Skip to content

Conversation

@CarlosRoca13
Copy link
Contributor

@CarlosRoca13 CarlosRoca13 commented Dec 24, 2020

cc @ Tecnativa TT26412

This migration depends on:

please @carlosdauden @pedrobaeza review this

@CarlosRoca13 CarlosRoca13 changed the title 14.0 mig account banking pain base [14.0] [MIG] account_banking_pain_base: Migration to v14 Dec 24, 2020
@pedrobaeza pedrobaeza added this to the 14.0 milestone Jan 5, 2021
Alexis de Lattre and others added 27 commits January 5, 2021 16:20
…13-11-21:

- add module account_banking_pain_base
- add support for initiating party identification, priority and structured remittance info in XML file
- the requested execution date now uses the fields date_prefered and date_scheduled (the field of the wizard has been removed)
- the 'convert to ascii' feature is now an option of the payment mode (enabled by default)
- set 'communication' field of payment.line to 140 chars and hide field 'communication2'
- Code factoring for SCT and SDD
- Add support for direct debit migration from national format to SEPA
- Source : Standard-XML-SDD-Initiation-v3-EN by Febelfin
- Add group in order to mask the fields for "Original Mandate Indentification" for users in countries that don't required it.
- Add tracking on important fields of the mandate.
- Better form view on company.
- Update constraint on mandate following my devs on "Original Mandate Identification".
- Add support for Party Identifier for Belgium. Can be easily extended for other countries.
- Mutualize more code between SCT and SDD.
* Make it easier to extend structured communication types.
* Use new style to make selection extendable.
* Help text for bank and BIC fields. Courtesy of Alexis de Lattre.
* Do not use InstrPrty for Direct Debit.
…ayment.lines object to allow grouping in the payments
* Add support for non-SEPA DD and CT without without IBANs
* Add hooks for l10n_ch_sepa (pain.001.001.03.ch.02)
* Move code of account_banking_pain_base/models/banking_export_pain.py to account_banking_pain_base/models/account_payment_order.py
* Add postal address in party block
* Adds flexibility to support direct debit direct debit for switzerland (pain.008.001.02.ch.01)
* Implement SEPA Core recommandations for postal address
* Add field local_instrument in payment lines and bank payment lines
* Add the bank_line as argument to some methods that generate SEPA XML
Port almost all modules to v10

* Update to EPC Rulebook v9.2 that start to apply on 2016-11-20 (bug OCA#300)
Add local instrument 'INST' for SEPA Instant Credit Transfer
Now the visibility is controlled through a security group.
Currently translated at 9.6% (8 of 83 strings)

Translation: bank-payment-11.0/bank-payment-11.0-account_banking_pain_base
Translate-URL: https://translation.odoo-community.org/projects/bank-payment-11-0/bank-payment-11-0-account_banking_pain_base/it/
* Standard migration procedure
* README by fragments
* Fixed tests
* Change
* Fix related no readonly in account_banking_pain_base
* Override default partner bank account check on account_payment_partner
* Convert Python date to string
Prevent inserting BIC not respecting the SEPA pain schemas.
The bic fields is not required, so the constraint must take that into
consideration and accept empty bic.
@CarlosRoca13 CarlosRoca13 force-pushed the 14.0-MIG-account_banking_pain_base branch 2 times, most recently from 35b66e4 to b2fb6d6 Compare January 7, 2021 07:06
@CarlosRoca13
Copy link
Contributor Author

Travis and runbot green yet, please review it @pedrobaeza @joao-p-marques

@CarlosRoca13 CarlosRoca13 force-pushed the 14.0-MIG-account_banking_pain_base branch from b2fb6d6 to bf12dc9 Compare January 7, 2021 08:14
Copy link
Member

@joao-p-marques joao-p-marques left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review. LGTM 👍

Just a small comment.

Also, please add your Copyright at the top of the files you changed.

@CarlosRoca13 CarlosRoca13 force-pushed the 14.0-MIG-account_banking_pain_base branch from bf12dc9 to c71b7d2 Compare January 7, 2021 09:44
@CarlosRoca13
Copy link
Contributor Author

@joao-p-marques Changes done!

@CarlosRoca13 CarlosRoca13 force-pushed the 14.0-MIG-account_banking_pain_base branch from c71b7d2 to a2884e3 Compare January 7, 2021 10:05
@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 14.0-ocabot-merge-pr-761-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit f8277ad into OCA:14.0 Jan 7, 2021
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 3ada27b. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.