[14.0] [MIG] account_banking_sepa_direct_debit: Migration to v14 #773
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….001.02, pain.008.001.03 and pain.008.001.04. This module is not ready yet : the management of mandates is still missing. I am currently trying to get more information about these mandates to decide what is the best implemtation of the data model of the mandates (O2M on res.partner ? O2M os res.partner.bank ?).
* Restore scheme field in mandate view * Uncaught flake8 errors * Set args correctly for cron job * Split for removing stock dependency on sale * Remove old translations templates * More reorder on folder structure * Translation template files * Translations to spanish
* Transfer move: one transfer move for each payment.order with only 1 line in the transfer account for the total of the account move. Move the inherit of the 'Invoice' button of payment.order from account_banking_payment_transfer to account_banking_payment_export Demo data: Add a bank account + mandate on Agrolait, to be able to easily test multi-partner SEPA DD * mandates: search by reference, add group_by, add seq type in tree view * Add scheme in mandate tree+search view Replace tabs by spaces in mandate views account_banking_mandate/views/account_banking_mandate_view.xml: convert from dos to unix format * Add sale_ok and purchase_ok filters in partner/sale/purchase form views Use widget=selection for payment_mode_id fields Update demo data * Limit lenght of mandate reference, according to ISO 20022
Fix an important regression in account_banking_sepa_direct_debit: "Date of Last Debit" was not set any more Proper write of date_done with account_banking_payment_export is installed without account_banking_payment_transfer Add post-install script for date_sent on payment.order
…ion when there is more than one line with the same mandate.
* Add bank.payment.lines object to allow grouping in the payments * Add a hook to inherit grouping of the transfer account move line Use that new hook in SEPA direct debits Better variable names * FIX Reading wrong field for sequence type of SEPA DD Loop on bank payment lines instead of payment lines * Update automated tests and demo data * Add on_change on field 'type' of payment.mode for easier configuration
… numbers + es translations
* Remove unused POT files * Spanish translation * Fix mandate report layout
Now the visibility is controlled through a security group.
…ange Odoo has added a constraint for avoiding a company currency change if there are move lines, making these tests to fail, as the currency is changed to EUR. With this commit, we create a new company with EUR currency for avoiding the problem. This commit also changes account_banking_mandate for not duplicating mandate number, as it was detected during the test creation. Similar to 1f8e345
…equence_type (OCA#464) The sequence_type of mandates switches from First to Recurring: - BEFORE: when state switched from 'open' to 'generated' - NOW: when state switches from 'generated' to 'uploaded'
Currently translated at 100.0% (71 of 71 strings) Translation: bank-payment-13.0/bank-payment-13.0-account_banking_sepa_direct_debit Translate-URL: https://translation.odoo-community.org/projects/bank-payment-13-0/bank-payment-13-0-account_banking_sepa_direct_debit/es_AR/
- Unfold SDD test in 2 classes: the base with initialization + the other with tests - Internal variable for parametrizing the chart template to load
Currently translated at 100.0% (71 of 71 strings) Translation: bank-payment-13.0/bank-payment-13.0-account_banking_sepa_direct_debit Translate-URL: https://translation.odoo-community.org/projects/bank-payment-13-0/bank-payment-13-0-account_banking_sepa_direct_debit/es_AR/
…en dependency in tests As we were setting a new company with its CoA, we need to load in it one, but using l10n_generic_coa doesn't serve, as we don't depend on that module (and we shouldn't), but we are invoking its XML-ID for loading the CoA, trusting in the good faith that the module is available and installed, which is not the case in some cases. Luckily, Odoo provides already an inheritable test for having a minimal CoA that doesn't require to load any chart. This PR uses that test and performs the minimal changes to adapt the module tests to it.
Currently translated at 100.0% (71 of 71 strings) Translation: bank-payment-13.0/bank-payment-13.0-account_banking_sepa_direct_debit Translate-URL: https://translation.odoo-community.org/projects/bank-payment-13-0/bank-payment-13-0-account_banking_sepa_direct_debit/es_AR/
joao-p-marques
approved these changes
Jan 14, 2021
account_banking_sepa_direct_debit/models/account_banking_mandate.py
Outdated
Show resolved
Hide resolved
pedrobaeza
requested changes
Jan 14, 2021
CarlosRoca13
force-pushed
the
14.0-MIG-account_banking_sepa_direct_debit
branch
from
847a0a5 to
f86c05f
Compare
|
The model TestAccountMultiCompanyNoChartCommon has dissapeared on 14.0, so I recover the field and method definition used on this tests from 13.0. Please, @pedrobaeza can you review it again? |
pedrobaeza
requested changes
Jan 24, 2021
…_sdd implementation
CarlosRoca13
force-pushed
the
14.0-MIG-account_banking_sepa_direct_debit
branch
from
f86c05f to
4cef4a8
Compare
|
@pedrobaeza I removed the not needed journals and |
pedrobaeza
approved these changes
Feb 8, 2021
|
/ocabot merge nobump |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at d7468f1. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
18 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @Tecnativa TT26414
This PR superseds #763
Please, @joao-p-marques @pedrobaeza can you review this?