Skip to content

[17.0][IMP]helpdesk_mgmt: better attachment support #663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 1, 2025
Merged

[17.0][IMP]helpdesk_mgmt: better attachment support #663

merged 3 commits into from
Apr 1, 2025

Conversation

PicchiSeba
Copy link

Fw-port of #642 for 17.0

@PicchiSeba PicchiSeba marked this pull request as ready for review November 29, 2024 13:57
@pedrobaeza pedrobaeza added this to the 17.0 milestone Nov 29, 2024
@github-actions GitHub Actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Mar 30, 2025
@marcelsavegnago
Copy link
Member

Hey @PicchiSeba, could you rebase this when you get a chance?

eLBati and others added 3 commits April 1, 2025 08:50
@eLBati @PicchiSeba
[IMP] helpdesk_mgmt: Show attachments on portal's ticket view
b94384c 
Forward port of 656c2d9

Note that the commit fc3905e (allow portal users to write tickets) has not been forward ported as it is not necessary
@ypapouin @PicchiSeba
[IMP] helpdesk_mgmt: Generate access_token for all attachments adde…
f79953b 
…d on ticket submit

Otherwise they stay "private" and are not displayed on the portal.
@ypapouin @PicchiSeba
[IMP] helpdesk_mgmt: Test submit with attachments
c40f504
@PicchiSeba PicchiSeba force-pushed the 17.0-better-attch-support branch from 865385a to c40f504 Compare April 1, 2025 06:50
@PicchiSeba
Copy link
Author

@marcelsavegnago there you go

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza
Copy link
Member

/ocabot merge patch

Please fw-port it to 18

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 17.0-ocabot-merge-pr-663-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 90b6c93 into OCA:17.0 Apr 1, 2025
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 1538628. Thanks a lot for contributing to OCA. ❤️

@PicchiSeba PicchiSeba deleted the 17.0-better-attch-support branch April 2, 2025 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcelsavegnago marcelsavegnago marcelsavegnago approved these changes

@pedrobaeza pedrobaeza pedrobaeza approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Milestone
17.0
Development

Successfully merging this pull request may close these issues.
6 participants
@PicchiSeba @marcelsavegnago @OCA-git-bot @pedrobaeza @eLBati @ypapouin