Skip to content

[17.0][IMP] helpdesk_type: Portal ticket type #725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 30, 2025
Merged

[17.0][IMP] helpdesk_type: Portal ticket type #725

merged 2 commits into from
Apr 30, 2025

Conversation

juancarlosonate-tecnativa
Copy link

  • Add configuration option to display the type in the new ticket portal view (portal form).
  • Add the type field to the portal ticket list (if the previous option is enabled).
  • Add the field to the portal ticket detail view.

@Tecnativa TT56029
@victoralmau @pedrobaeza @david-banon-tecnativa

@OCA-git-bot
Copy link
Contributor

Hi @max3903, @nelsonramirezs,
some modules you are maintaining are being modified, check this out!

@juancarlosonate-tecnativa juancarlosonate-tecnativa force-pushed the 17.0-imp-helpdesk_type branch 2 times, most recently from 2e59a7a to c37f97a Compare April 17, 2025 07:27
david-banon-tecnativa
david-banon-tecnativa reviewed Apr 17, 2025
View reviewed changes
Copy link
Contributor

@david-banon-tecnativa david-banon-tecnativa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Translations are missing, but otherwise looks good to me

victoralmau
victoralmau suggested changes Apr 21, 2025
View reviewed changes
Copy link
Member

@victoralmau victoralmau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you need to, add an initial commit to helpdesk_mgmt to add identifiers/name to the portal elements you need to make selectors easier and more useful in the future.

victoralmau
victoralmau reviewed Apr 22, 2025
View reviewed changes
@juancarlosonate-tecnativa
Copy link
Author

ping @victoralmau @david-banon-tecnativa some changes

@david-banon-tecnativa
Copy link
Contributor

david-banon-tecnativa commented Apr 22, 2025 •
edited
Loading

Portal user can't create ticket when show type in portal is enabled because it has no permissions to view types, missed that on my last review

@juancarlosonate-tecnativa
Copy link
Author

juancarlosonate-tecnativa commented Apr 22, 2025 •
edited
Loading

ping @david-banon-tecnativa @victoralmau

david-banon-tecnativa
david-banon-tecnativa approved these changes Apr 22, 2025
View reviewed changes
Copy link
Contributor

@david-banon-tecnativa david-banon-tecnativa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

victoralmau
victoralmau reviewed Apr 24, 2025
View reviewed changes
Copy link
Member

@victoralmau victoralmau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review OK.

IMO I don't like defining the options this way
ejemplo

I think it would be more appropriate to create a "section" for each field (teams, types and categories).
ejemplo2

What do you think @pedrobaeza ?

@pedrobaeza
Copy link
Member

Well, if everything is related a the "new ticket" form in portal, it's OK to go in the same config section, although being one for teams and another for types, but texts should be homogenized and texts rationalized for UX.

@juancarlosonate-tecnativa
Copy link
Author

juancarlosonate-tecnativa commented Apr 25, 2025 •
edited
Loading

like this? @pedrobaeza @victoralmau
image

@juancarlosonate-tecnativa
Copy link
Author

ping @pedrobaeza review and merge please?

@pedrobaeza pedrobaeza added this to the 17.0 milestone Apr 30, 2025
@pedrobaeza
Copy link
Member

/ocabot merge nobump

@pedrobaeza
Copy link
Member

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 17.0-ocabot-merge-pr-725-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Apr 30, 2025
@OCA-git-bot
Merge PR #725 into 17.0
4e4c69c 
Signed-off-by pedrobaeza
@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 17.0-ocabot-merge-pr-725-by-pedrobaeza-bump-minor, awaiting test results.

@OCA-git-bot
Copy link
Contributor

@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 17.0-ocabot-merge-pr-725-by-pedrobaeza-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@OCA-git-bot OCA-git-bot merged commit 41b8502 into OCA:17.0 Apr 30, 2025
5 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 0c9860c. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 17.0-imp-helpdesk_type branch April 30, 2025 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcelsavegnago marcelsavegnago marcelsavegnago approved these changes

@victoralmau victoralmau victoralmau approved these changes

@david-banon-tecnativa david-banon-tecnativa david-banon-tecnativa approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
17.0
Development

Successfully merging this pull request may close these issues.
6 participants
@juancarlosonate-tecnativa @OCA-git-bot @david-banon-tecnativa @pedrobaeza @marcelsavegnago @victoralmau