-
-
Notifications
You must be signed in to change notification settings - Fork 359
[17.0][IMP] helpdesk_mgmt: Add team hierarchy #728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please include tests for the display name with hierarchy, and shouldn't you define display_name
with recursive=True
?
@juancarlosonate-tecnativa you could take a look at #723 , that makes the same improvement with ticket categories (possibly with Pedro's suggestions), and review it as well |
Thank you very much, you're right. Also, the way you did it is just like the core does it. |
53c9394
to
4505ffa
Compare
@pedrobaeza @victoralmau @david-banon-tecnativa @dalonsod Review again, please and i realized that category_ids is not on the form, so it wasn't possible to add a category to the team |
/ocabot merge minor |
Hey, thanks for contributing! Proceeding to merge this for you. |
Congratulations, your PR was merged at 57f7b74. Thanks a lot for contributing to OCA. ❤️ |
Add team parent and compute the display name
@Tecnativa TT56101
@david-banon-tecnativa @victoralmau