Skip to content

[17.0][IMP] helpdesk_mgmt: Add team hierarchy #728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 25, 2025

Conversation

juancarlosonate-tecnativa

Add team parent and compute the display name

@Tecnativa TT56101
@david-banon-tecnativa @victoralmau

Copy link
Contributor

@david-banon-tecnativa david-banon-tecnativa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@pedrobaeza pedrobaeza added this to the 17.0 milestone Apr 24, 2025
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please include tests for the display name with hierarchy, and shouldn't you define display_name with recursive=True?

@dalonsod
Copy link
Contributor

@juancarlosonate-tecnativa you could take a look at #723 , that makes the same improvement with ticket categories (possibly with Pedro's suggestions), and review it as well

@juancarlosonate-tecnativa
Copy link
Author

@juancarlosonate-tecnativa you could take a look at #723 , that makes the same improvement with ticket categories (possibly with Pedro's suggestions), and review it as well

Thank you very much, you're right. Also, the way you did it is just like the core does it.

@juancarlosonate-tecnativa
Copy link
Author

@pedrobaeza @victoralmau @david-banon-tecnativa @dalonsod Review again, please and i realized that category_ids is not on the form, so it wasn't possible to add a category to the team

@pedrobaeza
Copy link
Member

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 17.0-ocabot-merge-pr-728-by-pedrobaeza-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 9dd8cb3 into OCA:17.0 Apr 25, 2025
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 57f7b74. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants