-
-
Notifications
You must be signed in to change notification settings - Fork 359
[17.0][FIX] helpdesk_mgmt_timesheet: Fix error when see timesheets reports #731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
582555d
to
b332bb6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested in runboat and It seems that it solves the problem, LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also tested in runboat both cases, and for a non-helpdesk user 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
It's ready for merge @pedrobaeza ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fw-port to 18
/ocabot merge patch
This PR looks fantastic, let's merge it! |
Congratulations, your PR was merged at da81e89. Thanks a lot for contributing to OCA. ❤️ |
Issue #730
cc https://github.com/APSL 9141
@miquelalzanillas @lbarry-apsl @javierobcn @mpascuall @BernatObrador @ppyczko please review