Skip to content

[17.0][FIX] helpdesk_mgmt_timesheet: Fix error when see timesheets reports #731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 25, 2025

Conversation

peluko00
Copy link
Contributor

@peluko00 peluko00 commented Apr 24, 2025

@peluko00 peluko00 force-pushed the 17.0-fix-helpdesk_mgmt_timesheet branch from 582555d to b332bb6 Compare April 24, 2025 10:00
Copy link

@mpascuall mpascuall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in runboat and It seems that it solves the problem, LGTM

Copy link
Contributor

@dalonsod dalonsod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also tested in runboat both cases, and for a non-helpdesk user 👍

Copy link

@ppyczko ppyczko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@peluko00
Copy link
Contributor Author

It's ready for merge @pedrobaeza ?

@pedrobaeza pedrobaeza changed the title [FIX] helpdesk_mgmt_timesheet: Fix error when see timesheets reports [17.0][FIX] helpdesk_mgmt_timesheet: Fix error when see timesheets reports Apr 25, 2025
@pedrobaeza pedrobaeza added this to the 17.0 milestone Apr 25, 2025
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fw-port to 18

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 17.0-ocabot-merge-pr-731-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit d3e99fe into OCA:17.0 Apr 25, 2025
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at da81e89. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug when see timesheets reports or when install sale_timesheet with helpdesk_mgmt_timesheet module installed
6 participants