Open
Conversation
etobella
force-pushed
the
18.0-timesheet
branch
2 times, most recently
from
4a5e8d0 to
6a7d1c5
Compare
etobella
force-pushed
the
18.0-timesheet
branch
from
6a7d1c5 to
881959c
Compare
luisDIXMIT
approved these changes
Jan 8, 2026
Contributor
luisDIXMIT
left a comment
luisDIXMIT
left a comment
There was a problem hiding this comment.
Code review and tested on runboat, LGTM. Only one minor comment.
| domain="[('is_service', '=', True), ('order_partner_id.commercial_partner_id.id', 'parent_of', parent.partner_id), ('is_expense', '=', False), ('state', '=', 'sale'), ('is_downpayment', '=', False)]" | ||
| optional="hide" | ||
| /> | ||
| <field |
Contributor
There was a problem hiding this comment.
It’s the same field with the same configuration, but one is visible to salespeople and the other to the rest of the groups. Is it correct?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #829
Allows to define sale order line directly on tickets, in a similar way that we have in PRoject tasks