[18.0][MIG] product_variant_route_mto: Migration to 18.0 #1879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Define route_ids as computed on the product variant, in order to reuse route_ids from its template and add or remove MTO route according to the setting on the variant. In case MTO route is changed on the template, it must reset any variant specific setting.
jbaudoux
approved these changes
Feb 6, 2025
grindtildeath
suggested changes
Feb 6, 2025
| "stock.route", | ||
| compute="_compute_route_ids", | ||
| domain="[('product_selectable', '=', True)]", | ||
| store=True, |
There was a problem hiding this comment.
IMO we do not want to store this field and must define a search function instead.
The goal with this field is to use the route_ids from the template - plus/minus the MTO route depending on the setting of the variant - when reading/searching on the product variant. By storing this, the route_ids from the template will not be used anymore, with the possibility to have inconsistencies between product and template as the product variant routes will not reflect anymore the routes from the template.
There was a problem hiding this comment.
Please point the open PR in v14 fixing this so that it can be ported once finished
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OCA/stock-logistics-workflowtoOCA/product-attribute, rename itproduct_variant_route_mtoroute_idsstored=Truebecause this code made errorNon-stored field product.product.route_ids cannot be searched.