-
-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[18.0][MIG] product_variant_route_mto: Migration to 18.0 #1879
Open
chaule97
wants to merge
6
commits into
OCA:18.0
Choose a base branch
from
chaule97:product-attribute-18.0-mig-product_variant_route_mto
base: 18.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
ca6c280
Add mto_route_product_variant
mmequignon f3c7277
Refactor mto_route_product_variant
grindtildeath 223a8ea
fixup! Refactor mto_route_product_variant
mmequignon ba09f39
[IMP] stock_product_variant_mto: pre-commit auto fixes
chaule97 4e686f1
[MIG] stock_product_variant_mto: Migration to 18.0
chaule97 6871f14
[MIG] rename stock_product_variant_mto
chaule97 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,102 @@ | ||
========================= | ||
Product Variant Route MTO | ||
========================= | ||
|
||
.. | ||
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! | ||
!! This file is generated by oca-gen-addon-readme !! | ||
!! changes will be overwritten. !! | ||
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! | ||
!! source digest: sha256:19127c85672968523ba9dac247eafabed27aaff202e5e8cc20d87b1f6ee204c6 | ||
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! | ||
|
||
.. |badge1| image:: https://img.shields.io/badge/maturity-Alpha-red.png | ||
:target: https://odoo-community.org/page/development-status | ||
:alt: Alpha | ||
.. |badge2| image:: https://img.shields.io/badge/licence-AGPL--3-blue.png | ||
:target: http://www.gnu.org/licenses/agpl-3.0-standalone.html | ||
:alt: License: AGPL-3 | ||
.. |badge3| image:: https://img.shields.io/badge/github-OCA%2Fproduct--attribute-lightgray.png?logo=github | ||
:target: https://github.com/OCA/product-attribute/tree/18.0/product_variant_route_mto | ||
:alt: OCA/product-attribute | ||
.. |badge4| image:: https://img.shields.io/badge/weblate-Translate%20me-F47D42.png | ||
:target: https://translation.odoo-community.org/projects/product-attribute-18-0/product-attribute-18-0-product_variant_route_mto | ||
:alt: Translate me on Weblate | ||
.. |badge5| image:: https://img.shields.io/badge/runboat-Try%20me-875A7B.png | ||
:target: https://runboat.odoo-community.org/builds?repo=OCA/product-attribute&target_branch=18.0 | ||
:alt: Try me on Runboat | ||
|
||
|badge1| |badge2| |badge3| |badge4| |badge5| | ||
|
||
This module allows to define if a product variant can use the Make To | ||
Order route without any dependency on its template routes settings. | ||
|
||
The routes are moved from product template to product product. | ||
|
||
.. IMPORTANT:: | ||
This is an alpha version, the data model and design can change at any time without warning. | ||
Only for development or testing purpose, do not use in production. | ||
`More details on development status <https://odoo-community.org/page/development-status>`_ | ||
|
||
**Table of contents** | ||
|
||
.. contents:: | ||
:local: | ||
|
||
Bug Tracker | ||
=========== | ||
|
||
Bugs are tracked on `GitHub Issues <https://github.com/OCA/product-attribute/issues>`_. | ||
In case of trouble, please check there if your issue has already been reported. | ||
If you spotted it first, help us to smash it by providing a detailed and welcomed | ||
`feedback <https://github.com/OCA/product-attribute/issues/new?body=module:%20product_variant_route_mto%0Aversion:%2018.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_. | ||
|
||
Do not contact contributors directly about support or help with technical issues. | ||
|
||
Credits | ||
======= | ||
|
||
Authors | ||
------- | ||
|
||
* Camptocamp SA | ||
|
||
Contributors | ||
------------ | ||
|
||
- Matthieu Méquignon <[email protected]> | ||
- Akim Juillerat <[email protected]> | ||
- Chau Le <[email protected]> | ||
|
||
Other credits | ||
------------- | ||
|
||
The development and migration of this module has been financially | ||
supported by: | ||
|
||
- Camptocamp | ||
|
||
Maintainers | ||
----------- | ||
|
||
This module is maintained by the OCA. | ||
|
||
.. image:: https://odoo-community.org/logo.png | ||
:alt: Odoo Community Association | ||
:target: https://odoo-community.org | ||
|
||
OCA, or the Odoo Community Association, is a nonprofit organization whose | ||
mission is to support the collaborative development of Odoo features and | ||
promote its widespread use. | ||
|
||
.. |maintainer-mmequignon| image:: https://github.com/mmequignon.png?size=40px | ||
:target: https://github.com/mmequignon | ||
:alt: mmequignon | ||
|
||
Current `maintainer <https://odoo-community.org/page/maintainer-role>`__: | ||
|
||
|maintainer-mmequignon| | ||
|
||
This module is part of the `OCA/product-attribute <https://github.com/OCA/product-attribute/tree/18.0/product_variant_route_mto>`_ project on GitHub. | ||
|
||
You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
from . import models |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
# Copyright 2023 Camptocamp SA | ||
# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl) | ||
|
||
{ | ||
"name": "Product Variant Route MTO", | ||
"summary": "Allow to individually set variants as MTO", | ||
"version": "18.0.1.0.0", | ||
"development_status": "Alpha", | ||
"category": "Inventory", | ||
"website": "https://github.com/OCA/product-attribute", | ||
"author": "Camptocamp SA, Odoo Community Association (OCA)", | ||
"maintainers": ["mmequignon"], | ||
"license": "AGPL-3", | ||
"installable": True, | ||
"auto_install": False, | ||
"depends": ["stock"], | ||
"data": ["views/product_product.xml"], | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
from . import product_product | ||
from . import product_template |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,53 @@ | ||
# Copyright 2023 Camptocamp SA | ||
# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl) | ||
|
||
from odoo import api, fields, models | ||
|
||
IS_MTO_HELP = """ | ||
Check or Uncheck this field to enable the Make To Order on the variant, | ||
independantly from its template configuration.\n | ||
Please note that activating or deactivating Make To Order on the template, | ||
will reset this setting on its variants. | ||
""" | ||
|
||
|
||
class ProductProduct(models.Model): | ||
_inherit = "product.product" | ||
|
||
is_mto = fields.Boolean( | ||
string="Variant is MTO", | ||
compute="_compute_is_mto", | ||
store=True, | ||
readonly=False, | ||
help=IS_MTO_HELP, | ||
) | ||
|
||
route_ids = fields.Many2many( | ||
"stock.route", | ||
compute="_compute_route_ids", | ||
domain="[('product_selectable', '=', True)]", | ||
store=True, | ||
) | ||
|
||
def _compute_is_mto(self): | ||
mto_route = self.env.ref("stock.route_warehouse0_mto", raise_if_not_found=False) | ||
if not mto_route: | ||
self.update({"is_mto": False}) | ||
return | ||
|
||
for product in self: | ||
product.is_mto = mto_route in product.product_tmpl_id.route_ids | ||
|
||
@api.depends("is_mto", "product_tmpl_id.route_ids") | ||
def _compute_route_ids(self): | ||
mto_route = self.env.ref("stock.route_warehouse0_mto", raise_if_not_found=False) | ||
for product in self: | ||
template_routes = product.product_tmpl_id.route_ids | ||
|
||
if mto_route: | ||
if product.is_mto and mto_route not in template_routes: | ||
template_routes += mto_route | ||
elif not product.is_mto and mto_route in template_routes: | ||
template_routes -= mto_route | ||
|
||
product.route_ids = template_routes |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,70 @@ | ||
# Copyright 2023 Camptocamp SA | ||
# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl) | ||
|
||
from odoo import api, models | ||
|
||
|
||
class ProductTemplate(models.Model): | ||
_inherit = "product.template" | ||
|
||
def write(self, values): | ||
mto_route = self.env.ref("stock.route_warehouse0_mto", raise_if_not_found=False) | ||
|
||
if "route_ids" not in values or not mto_route: | ||
return super().write(values) | ||
|
||
# As _compute_is_mto cannot use api.depends (or it would reset MTO | ||
# route on variants as soon as there is a change on the template routes), | ||
# we need to check which template in self had MTO route activated | ||
# or deactivated to force the recomputation of is_mto on variants | ||
|
||
templates_not_mto_before = self.filtered(lambda t: mto_route not in t.route_ids) | ||
|
||
res = super().write(values) | ||
|
||
templates_mto_after = self.filtered(lambda t: mto_route in t.route_ids) | ||
templates_mto_added = templates_not_mto_before & templates_mto_after | ||
templates_mto_removed = self - templates_mto_after - templates_not_mto_before | ||
|
||
( | ||
templates_mto_added | templates_mto_removed | ||
).product_variant_ids._compute_is_mto() | ||
|
||
return res | ||
|
||
@api.onchange("route_ids") | ||
def onchange_route_ids(self): | ||
mto_route = self.env.ref("stock.route_warehouse0_mto", raise_if_not_found=False) | ||
if not mto_route: | ||
return | ||
|
||
origin_routes = ( | ||
self._origin.route_ids if self._origin else self.env["stock.route"] | ||
) | ||
current_routes = ( | ||
self.route_ids._origin if self.route_ids else self.env["stock.route"] | ||
) | ||
|
||
if mto_route not in origin_routes and mto_route in current_routes: | ||
# Return warning activating MTO route | ||
return { | ||
"warning": { | ||
"title": self.env._("Warning"), | ||
"message": self.env._( | ||
"Activating MTO route will reset `Variant is MTO` " | ||
"setting on the variants." | ||
), | ||
} | ||
} | ||
|
||
if mto_route in origin_routes and mto_route not in current_routes: | ||
# Return warning deactivating MTO route | ||
return { | ||
"warning": { | ||
"title": self.env._("Warning"), | ||
"message": self.env._( | ||
"Deactivating MTO route will reset `Variant is MTO` " | ||
"setting on the variants." | ||
), | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
[build-system] | ||
requires = ["whool"] | ||
build-backend = "whool.buildapi" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
The checkbox `Variant is MTO` on the product variant allows | ||
to force usage or non-usage of the MTO route for the variant. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
- Matthieu Méquignon \<<[email protected]>\> | ||
- Akim Juillerat \<<[email protected]>\> | ||
- Chau Le \<<[email protected]>\> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
The development and migration of this module has been financially supported by: | ||
|
||
- Camptocamp |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
This module allows to define if a product variant can use the Make To | ||
Order route without any dependency on its template routes settings. | ||
|
||
The routes are moved from product template to product product. |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO we do not want to store this field and must define a search function instead.
The goal with this field is to use the
route_ids
from the template - plus/minus the MTO route depending on the setting of the variant - when reading/searching on the product variant. By storing this, the route_ids from the template will not be used anymore, with the possibility to have inconsistencies between product and template as the product variant routes will not reflect anymore the routes from the template.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please point the open PR in v14 fixing this so that it can be ported once finished