Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][ADD] purchase_product_packaging_container_deposit #2034

Conversation

santostelmo
Copy link
Contributor

@santostelmo santostelmo commented Oct 12, 2023

Add purchase_product_packaging_container_deposit

@santostelmo santostelmo changed the title [ADD] purchase_product_packaging_container_deposit [16.0][ADD] purchase_product_packaging_container_deposit Oct 12, 2023
@santostelmo santostelmo force-pushed the 16.0-add-purchase_product_packaging_container_deposit branch 3 times, most recently from 4119a6b to aae5cf7 Compare October 20, 2023 07:14
@santostelmo santostelmo force-pushed the 16.0-add-purchase_product_packaging_container_deposit branch 3 times, most recently from 849f1ae to 1ca23b3 Compare October 25, 2023 13:45
@santostelmo santostelmo force-pushed the 16.0-add-purchase_product_packaging_container_deposit branch from 1ca23b3 to 381d31d Compare October 30, 2023 15:01
@santostelmo santostelmo force-pushed the 16.0-add-purchase_product_packaging_container_deposit branch from 381d31d to 8f5c173 Compare November 6, 2023 08:22
@cyrilmanuel
Copy link
Contributor

Missing unit price for Products: Product A, in unitest

@santostelmo santostelmo force-pushed the 16.0-add-purchase_product_packaging_container_deposit branch from 5dc0b47 to 56f84cb Compare November 21, 2023 12:18
@santostelmo
Copy link
Contributor Author

Missing unit price for Products: Product A, in unitest

Yes. That was a requirements from another module: purchase_order_no_zero_price

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@santostelmo
Copy link
Contributor Author

@simahawk I updated code with fix done in sale-workflow OCA/sale-workflow#2833

Copy link

@simahawk simahawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, just one thing more

@santostelmo santostelmo force-pushed the 16.0-add-purchase_product_packaging_container_deposit branch from 6cba8ca to afac557 Compare December 6, 2023 09:13
sale_product_packaging_container_deposit: update contributors

purchase_product_packaging_container_deposit: fix qty delivered update

[IMP] purchase_product_packaging_container_deposit: Unit test delete container deposit lines
@simahawk simahawk force-pushed the 16.0-add-purchase_product_packaging_container_deposit branch from afac557 to a21ba45 Compare December 15, 2023 08:26
@simahawk simahawk self-requested a review December 15, 2023 08:33
@simahawk
Copy link

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-2034-by-simahawk-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit cd5bf03 into OCA:16.0 Dec 15, 2023
9 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at f23bc96. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants