[16.0][ADD] attachment_log #3161

geomer198 · 2025-01-09T17:48:17Z

This module adds the following features for attachments:

Displays the date and time when each attachment was added under the attachment file
Records chatter messages showing which user linked or unlinked files to attachments

attachment_log/models/ir_attachment.py

ivs-cetmix

Here are my concerns: why should we post a message for every attachment added?
What if an incoming email arrives with 10+ attachments in it? It will result in 10+ messages trashing the record chatter.
You can simply show name of the user who added attachment together with the creation date. That is.

attachment_log/__manifest__.py

ivs-cetmix

You should add test coverage for the features you are adding.

attachment_log/models/ir_attachment.py

attachment_log/__manifest__.py

attachment_log/models/ir_attachment.py

attachment_log/__manifest__.py

attachment_log/readme/DESCRIPTION.rst

attachment_log/models/ir_attachment.py

ivs-cetmix

You need to add CONFIGURE.rts to explain the configuration process.

To enable note logging of attachment operations in record chatter: 

- Go to "Settings > General Settings" and scroll to the "Discuss" section.
- Activate the "Attachment Logging" checkbox.

Add screenshots that make both configuration and usage easier. Must be not more than 800px width.
Here is an example. Don't use this picture because you need to fix the configuration view first.

attachment_logging/__manifest__.py

attachment_logging/models/res_config_settings.py

attachment_logging/readme/USAGE.rst

attachment_logging/views/res_config_settings_views.xml

ivs-cetmix

Code review LGTM

yostashiro · 2025-01-19T23:39:17Z

Just noticed that I don't seem to be able to attach a file in a message (upload doesn't complete) when the feature is activated (tested in Runboat). Can you please check?

ivs-cetmix · 2025-01-21T10:00:41Z

Just noticed that I don't seem to be able to attach a file in a message (upload doesn't complete) when the feature is activated (tested in Runboat). Can you please check?

Hi @yostashiro! Thank you for noticing that! Will fix.

xxp-odoo

Functionality LGTM

geomer198 · 2025-03-03T21:16:35Z

Just noticed that I don't seem to be able to attach a file in a message (upload doesn't complete) when the feature is activated (tested in Runboat). Can you please check?

Thank you for your comment. I have tested your problem on runboat and everything works correctly.

ivs-cetmix · 2025-03-16T13:38:43Z

Hi @yostashiro could you please check again on the runboat?

yostashiro · 2025-03-17T09:44:36Z

Took a quick look in runboat and noticed a couple of things:

1/ When I attach a file directly to the thread (not via send message or log note), the user and date information doesn't seem to be assigned to the attachment.

2/ The assigned date seems to show in UTC. The best would be to show it in user's timezone.

If these are as intended, we may want to update the README to mention these?

geomer198 · 2025-03-25T08:24:43Z

@yostashiro Could you please check again?

yostashiro

Functional test. LGTM with a question.

I'm not sure how to interpret the CI error.

yostashiro · 2025-03-26T02:00:41Z

attachment_logging/models/ir_attachment.py

+        tz = self._context.get("tz") or self.env.user.tz
+        create_date = self.create_date
+        create_date = Datetime.context_timestamp(
+            self.with_context(tz=tz), timestamp=create_date
+        )


I wasn't sure this conversion was necessary on the server side. Does it not work if we just return the raw self.create_date and use widget="datetime" in the view?

rvalyi · 2025-03-26T02:12:57Z

Merging based on the reviews.
/ocabot merge nobump

rvalyi · 2025-03-27T01:53:38Z

/ocabot merge nobump

ivs-cetmix · 2025-03-31T06:36:55Z

Hi @rvalyi , looks like the merge process has stuck here. @sbidoul could you please have a look too?

Christian-RB

I think this is a pretty good feature and tests seems to be failing for different reason. Code and functional review LGTM

ivs-cetmix · 2025-05-01T11:19:39Z

/ocabot merge nobump

OCA-git-bot · 2025-05-01T11:19:46Z

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-3161-by-ivs-cetmix-bump-nobump, awaiting test results.

Signed-off-by ivs-cetmix

OCA-git-bot · 2025-05-01T11:27:39Z

@ivs-cetmix your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-3161-by-ivs-cetmix-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

Christian-RB · 2025-05-08T11:37:23Z

@geomer198 Can you rebase de code to retry the tests?

attachment_logging/models/ir_attachment.py

geomer198 · 2025-06-14T20:16:25Z

@geomer198 Can you rebase de code to retry the tests?

Done!

xxp-odoo · 2025-06-20T08:40:47Z

@Christian-RB
Could you please proceed with the merge?

Christian-RB · 2025-06-20T11:22:06Z

@ivs-cetmix Can you retry the merge command? Thanks in advance

ivs-cetmix · 2025-06-20T11:30:37Z

/ocabot merge nobump

OCA-git-bot · 2025-06-20T11:30:44Z

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-3161-by-ivs-cetmix-bump-nobump, awaiting test results.

OCA-git-bot · 2025-06-20T11:47:55Z

Congratulations, your PR was merged at c89a36e. Thanks a lot for contributing to OCA. ❤️

geomer198 force-pushed the 16.0-t4242-attachment-log-add branch from 9b18974 to fc0cd0a Compare January 9, 2025 17:48

hoangtrann suggested changes Jan 11, 2025

View reviewed changes

attachment_log/models/ir_attachment.py Outdated Show resolved Hide resolved

ivs-cetmix requested changes Jan 11, 2025

View reviewed changes

attachment_log/__manifest__.py Outdated Show resolved Hide resolved

ivs-cetmix requested changes Jan 14, 2025

View reviewed changes

geomer198 force-pushed the 16.0-t4242-attachment-log-add branch 2 times, most recently from 7e55b4c to 81f090d Compare January 15, 2025 21:44

ivs-cetmix requested changes Jan 16, 2025

View reviewed changes

ivs-cetmix approved these changes Jan 19, 2025

View reviewed changes

xxp-odoo approved these changes Feb 3, 2025

View reviewed changes

geomer198 force-pushed the 16.0-t4242-attachment-log-add branch from 2dea328 to e9d0365 Compare March 24, 2025 15:17

yostashiro approved these changes Mar 26, 2025

View reviewed changes

geomer198 force-pushed the 16.0-t4242-attachment-log-add branch from e9d0365 to 4e3d7c5 Compare April 16, 2025 13:56

Christian-RB approved these changes Apr 28, 2025

View reviewed changes

OCA-git-bot added a commit that referenced this pull request May 1, 2025

Merge PR #3161 into 16.0

66e4acc

Signed-off-by ivs-cetmix

OCA-git-bot added the bot is merging ⏳ label May 1, 2025

OCA-git-bot removed the bot is merging ⏳ label May 1, 2025

adasatorres approved these changes May 6, 2025

View reviewed changes

adasatorres suggested changes Jun 11, 2025

View reviewed changes

attachment_logging/models/ir_attachment.py Outdated Show resolved Hide resolved

Christian-RB mentioned this pull request Jun 12, 2025

[17.0][MIG] attachment log: Migration to 17.0 #3309

Open

geomer198 force-pushed the 16.0-t4242-attachment-log-add branch from 4e3d7c5 to 9dead3b Compare June 14, 2025 17:41

[ADD] attachment_logging: Module added

7fe2718

geomer198 force-pushed the 16.0-t4242-attachment-log-add branch from 9dead3b to 7fe2718 Compare June 14, 2025 20:07

OCA-git-bot added the bot is merging ⏳ label Jun 20, 2025

OCA-git-bot merged commit 554a155 into OCA:16.0 Jun 20, 2025
8 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Jun 20, 2025

ivs-cetmix deleted the 16.0-t4242-attachment-log-add branch June 20, 2025 12:45

Uh oh!

[16.0][ADD] attachment_log #3161

[16.0][ADD] attachment_log #3161

Uh oh!

Conversation

geomer198 commented Jan 9, 2025

Uh oh!

Uh oh!

ivs-cetmix left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ivs-cetmix left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ivs-cetmix left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ivs-cetmix left a comment

Choose a reason for hiding this comment

Uh oh!

yostashiro commented Jan 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ivs-cetmix commented Jan 21, 2025

Uh oh!

xxp-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

geomer198 commented Mar 3, 2025

Uh oh!

ivs-cetmix commented Mar 16, 2025

Uh oh!

yostashiro commented Mar 17, 2025

Uh oh!

geomer198 commented Mar 25, 2025

Uh oh!

yostashiro left a comment

Choose a reason for hiding this comment

Uh oh!

yostashiro Mar 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rvalyi commented Mar 26, 2025

Uh oh!

rvalyi commented Mar 27, 2025

Uh oh!

ivs-cetmix commented Mar 31, 2025

Uh oh!

Christian-RB left a comment

Choose a reason for hiding this comment

Uh oh!

ivs-cetmix commented May 1, 2025

Uh oh!

OCA-git-bot commented May 1, 2025

Uh oh!

OCA-git-bot commented May 1, 2025

Uh oh!

Christian-RB commented May 8, 2025

Uh oh!

Uh oh!

geomer198 commented Jun 14, 2025

Uh oh!

xxp-odoo commented Jun 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

yostashiro commented Jan 19, 2025 •

edited

Loading

yostashiro Mar 26, 2025 •

edited

Loading

xxp-odoo commented Jun 20, 2025 •

edited

Loading