[15.0][ADD] stock_picking_auto_revert #1491
Conversation
AaronHForgeFlow
force-pushed
the
15.0-add-stock_picking_auto_revert
branch
from
cd043c6 to
d986370
Compare
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
AaronHForgeFlow
force-pushed
the
15.0-add-stock_picking_auto_revert
branch
from
d986370 to
d8c959b
Compare
| # Restrictions before remove quants | ||
| if self.returned_move_ids: | ||
| raise exceptions.UserError( | ||
| _("Action not allowed. Move splited / with returned moves.") |
There was a problem hiding this comment.
| _("Action not allowed. Move splited / with returned moves.") | |
| _("You cannot revert this stock picking. Move splited / with returned moves.") |
There was a problem hiding this comment.
Suggestion applied.
AaronHForgeFlow
force-pushed
the
15.0-add-stock_picking_auto_revert
branch
from
d8c959b to
861c733
Compare
|
Thanks @GuillemCForgeFlow I added the original picking name between brackets, like this:
|
github-actions
bot
removed
the
stale
AaronHForgeFlow
force-pushed
the
15.0-add-stock_picking_auto_revert
branch
from
861c733 to
24343d2
Compare
AaronHForgeFlow
force-pushed
the
15.0-add-stock_picking_auto_revert
branch
from
24343d2 to
f122697
Compare
|
@AaronHForgeFlow Maybe testing exceptions could be great |
AaronHForgeFlow
force-pushed
the
15.0-add-stock_picking_auto_revert
branch
from
f122697 to
05ddb6c
Compare
|
@rousseldenis tests added :) |
A module that passed several versions :-) |
| move._check_restrictions() | ||
|
|
||
| def action_revert_recreate(self): | ||
| self.ensure_one() |
There was a problem hiding this comment.
And one more question.
Should'nt it be more interesting to do a wizard for that flow ?
There was a problem hiding this comment.
Perhaps. I did it this way because the users just want less clicks as possible. I prefer not to change it, if not necessary.
AaronHForgeFlow
force-pushed
the
15.0-add-stock_picking_auto_revert
branch
from
05ddb6c to
02b3ccb
Compare
| "You cannot revert this stock picking. Its stock moves are linked to " | ||
| "other moves. Origin pickings: {origin_pickings}. " | ||
| "Destination pickings: {destination_pickings}." | ||
| ).format( |
There was a problem hiding this comment.
Ooops, don't use format() but use translation function arguments.
There was a problem hiding this comment.
Yes, sorry for this. It is now fixed.
AaronHForgeFlow
force-pushed
the
15.0-add-stock_picking_auto_revert
branch
from
02b3ccb to
78a511a
Compare
Module to correct mistakes in pickings the fast way. Instead of cancel this module will create a return and then will recreate the issued picking.
Based on #593 Originally it was discarded because of the stock_cancel module.
Similar approach Odoo uses for correcting mistakes in invoices. that is, do a reverse and recreate the original invoice in draft state so the user can edit it.
cc @ForgeFlow
This PR Replaces: OCA/stock-logistics-warehouse#1918