Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0][ADD] stock_picking_auto_revert #1491

Open
wants to merge 3 commits into
base: 15.0
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions setup/stock_picking_auto_revert/setup.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
import setuptools

setuptools.setup(
setup_requires=['setuptools-odoo'],
odoo_addon=True,
)
84 changes: 84 additions & 0 deletions stock_picking_auto_revert/README.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1,84 @@
=========================
Stock Picking Auto Revert
=========================

..
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
!! This file is generated by oca-gen-addon-readme !!
!! changes will be overwritten. !!
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
!! source digest: sha256:29c9d30208826b683501ead088c6e62d10cfd71a497b414fde82121d85322db0
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!

.. |badge1| image:: https://img.shields.io/badge/maturity-Beta-yellow.png
:target: https://odoo-community.org/page/development-status
:alt: Beta
.. |badge2| image:: https://img.shields.io/badge/licence-AGPL--3-blue.png
:target: http://www.gnu.org/licenses/agpl-3.0-standalone.html
:alt: License: AGPL-3
.. |badge3| image:: https://img.shields.io/badge/github-OCA%2Fstock--logistics--workflow-lightgray.png?logo=github
:target: https://github.com/OCA/stock-logistics-workflow/tree/15.0/stock_picking_auto_revert
:alt: OCA/stock-logistics-workflow
.. |badge4| image:: https://img.shields.io/badge/weblate-Translate%20me-F47D42.png
:target: https://translation.odoo-community.org/projects/stock-logistics-workflow-15-0/stock-logistics-workflow-15-0-stock_picking_auto_revert
:alt: Translate me on Weblate
.. |badge5| image:: https://img.shields.io/badge/runboat-Try%20me-875A7B.png
:target: https://runboat.odoo-community.org/builds?repo=OCA/stock-logistics-workflow&target_branch=15.0
:alt: Try me on Runboat

|badge1| |badge2| |badge3| |badge4| |badge5|

Corrrect mistakes in pickings. Instead of cancel this module will create a
return and then will recreate the issued picking.

**Table of contents**

.. contents::
:local:

Usage
=====

In the picking click on Return and recreate button. It will be the same as
doing a return and then duplicate the original picking. Do not use for actual
returns.

Bug Tracker
===========

Bugs are tracked on `GitHub Issues <https://github.com/OCA/stock-logistics-workflow/issues>`_.
In case of trouble, please check there if your issue has already been reported.
If you spotted it first, help us to smash it by providing a detailed and welcomed
`feedback <https://github.com/OCA/stock-logistics-workflow/issues/new?body=module:%20stock_picking_auto_revert%0Aversion:%2015.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.

Do not contact contributors directly about support or help with technical issues.

Credits
=======

Authors
~~~~~~~

* ForgeFlow

Contributors
~~~~~~~~~~~~

* Aaron Henriquez <[email protected]>

Maintainers
~~~~~~~~~~~

This module is maintained by the OCA.

.. image:: https://odoo-community.org/logo.png
:alt: Odoo Community Association
:target: https://odoo-community.org

OCA, or the Odoo Community Association, is a nonprofit organization whose
mission is to support the collaborative development of Odoo features and
promote its widespread use.

This module is part of the `OCA/stock-logistics-workflow <https://github.com/OCA/stock-logistics-workflow/tree/15.0/stock_picking_auto_revert>`_ project on GitHub.

You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute.
1 change: 1 addition & 0 deletions stock_picking_auto_revert/__init__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
from . import models
15 changes: 15 additions & 0 deletions stock_picking_auto_revert/__manifest__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
# Copyright 2019 ForgeFlow
# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).

{
"name": "Stock Picking Auto Revert",
"version": "15.0.1.0.0",
"category": "Stock",
"summary": "Returns and recreate the picking",
"author": "ForgeFlow, Odoo Community Association (OCA)",
"website": "https://github.com/OCA/stock-logistics-workflow",
"license": "AGPL-3",
"depends": ["sale_stock"],
"data": ["views/stock_views.xml"],
"installable": True,
}
2 changes: 2 additions & 0 deletions stock_picking_auto_revert/models/__init__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
from . import stock_move
from . import stock_picking
33 changes: 33 additions & 0 deletions stock_picking_auto_revert/models/stock_move.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
# Copyright 2019 ForgeFlow
# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).


from odoo import _, exceptions, models


class StockMove(models.Model):
_inherit = "stock.move"

def _check_restrictions(self):
# Restrictions before removing quants
if self.returned_move_ids:
raise exceptions.UserError(
_(
"You cannot revert this stock picking. Move splited / with returned moves."
)
)
if self.move_dest_ids or self.search([("move_dest_ids", "in", self.ids)]):
origin_pickings = ", ".join(self.mapped("picking_id.name"))
destination_pickings = ", ".join(

Check warning on line 21 in stock_picking_auto_revert/models/stock_move.py

View check run for this annotation

Codecov / codecov/patch

stock_picking_auto_revert/models/stock_move.py#L20-L21

Added lines #L20 - L21 were not covered by tests
self.mapped("move_dest_ids.picking_id.name")
)
raise exceptions.UserError(

Check warning on line 24 in stock_picking_auto_revert/models/stock_move.py

View check run for this annotation

Codecov / codecov/patch

stock_picking_auto_revert/models/stock_move.py#L24

Added line #L24 was not covered by tests
_(
"You cannot revert this stock picking. Its stock moves are linked to "
"other moves. Origin pickings: "
)
+ origin_pickings
+ _(". Destination pickings: ")
+ destination_pickings
+ "."
)
63 changes: 63 additions & 0 deletions stock_picking_auto_revert/models/stock_picking.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,63 @@
# Copyright 2019 ForgeFlow
# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).

from odoo import _, exceptions, models


class StockPicking(models.Model):
_inherit = "stock.picking"

def _check_restrictions(self):
# returned_move_ids in stock.move
# split_from in stock.move
for move in self.move_lines:
move._check_restrictions()

def action_revert_recreate(self):
self.ensure_one()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And one more question.

Should'nt it be more interesting to do a wizard for that flow ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps. I did it this way because the users just want less clicks as possible. I prefer not to change it, if not necessary.

pick = self
pick._check_restrictions()
msg = _(
"Too bad. This picking cannot be returned because the products "
"are not available in the destination location"
)
# Create return picking
StockReturnPicking = self.env["stock.return.picking"]
default_data = StockReturnPicking.with_context(
active_model="stock.picking", active_id=pick.id
).default_get(
[
"move_dest_exists",
"original_location_id",
"product_return_moves",
"parent_location_id",
"location_id",
]
)
default_data.update({"location_id": pick.location_id.id})
return_wiz = StockReturnPicking.create(default_data)
return_wiz._onchange_picking_id()
self.check_return_quantities(return_wiz, pick, msg)
res = return_wiz.create_returns()
return_pick = self.env["stock.picking"].browse(res["res_id"])
# Validate picking
return_pick.action_set_quantities_to_reservation()
return_pick._action_done()
new_pick = pick.copy()
new_pick.origin = new_pick.origin + " ({pick_name})".format(pick_name=pick.name)
new_pick.action_assign()
result = self.env["ir.actions.act_window"]._for_xml_id(
"stock.action_picking_tree_all"
)
res = self.env.ref("stock.view_picking_form", False)
result["views"] = [(res and res.id or False, "form")]
result["res_id"] = new_pick.id
return result

def check_return_quantities(self, return_wiz, pick, msg):
for rm in return_wiz.product_return_moves:
sm = pick.move_lines.filtered(
lambda x: x.product_id.id == rm.product_id.id and x.state == "done"
)
if rm.quantity < sum(sm.mapped("product_uom_qty")):
raise exceptions.UserError(msg)

Check warning on line 63 in stock_picking_auto_revert/models/stock_picking.py

View check run for this annotation

Codecov / codecov/patch

stock_picking_auto_revert/models/stock_picking.py#L63

Added line #L63 was not covered by tests
1 change: 1 addition & 0 deletions stock_picking_auto_revert/readme/CONTRIBUTORS.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
* Aaron Henriquez <[email protected]>
2 changes: 2 additions & 0 deletions stock_picking_auto_revert/readme/DESCRIPTION.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Corrrect mistakes in pickings. Instead of cancel this module will create a
return and then will recreate the issued picking.
3 changes: 3 additions & 0 deletions stock_picking_auto_revert/readme/USAGE.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
In the picking click on Return and recreate button. It will be the same as
doing a return and then duplicate the original picking. Do not use for actual
returns.
Loading
Loading