[18.0][MIG] stock_partner_delivery_window: Migration to 18.0 #1783
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivantodorovich
approved these changes
Jan 6, 2025
|
/ocabot migration stock_partner_delivery_window |
|
This PR has the |
rousseldenis
requested changes
Jan 10, 2025
| domain = [("partner_id", "in", self.ids)] | ||
| if day_name is not None: | ||
| week_day_id = self.env["time.weekday"]._get_id_by_name(day_name) | ||
| domain.append(("time_window_weekday_ids", "in", week_day_id)) |
There was a problem hiding this comment.
append is never a good idea. Using expression.AND() is better.
| } | ||
| for window_id in self.delivery_time_window_ids | ||
| ] | ||
| result["delivery_time_window_ids"] = [(0, 0, val) for val in values] |
There was a problem hiding this comment.
Minor comment, using Command is IMHO better.
| message = self.env._( | ||
| "The scheduled date is {date} ({weekday}), but the partner is " | ||
| "set to prefer deliveries on working days." | ||
| ).format( |
There was a problem hiding this comment.
You should use translate function arguments instead.
| def _planned_delivery_date(self): | ||
| return self.scheduled_date | ||
|
|
||
| @api.onchange("scheduled_date") |
There was a problem hiding this comment.
IMHO, warnings could be avoided using alerts instead.
| @classmethod | ||
| def setUpClass(cls): | ||
| super().setUpClass() | ||
| cls.env = cls.env(context=dict(cls.env.context, tracking_disable=True)) |
There was a problem hiding this comment.
Use BaseCommon class to avoid this.
thienvh332
force-pushed
the
18.0-mig-stock_partner_delivery_window
branch
from
ba0b1b4 to
bce6c2f
Compare
rousseldenis
reviewed
Feb 4, 2025
| @@ -61,7 +58,9 @@ def get_delivery_windows(self, day_name=None): | |||
| domain = [("partner_id", "in", self.ids)] | |||
| if day_name is not None: | |||
| week_day_id = self.env["time.weekday"]._get_id_by_name(day_name) | |||
| domain.append(("time_window_weekday_ids", "in", week_day_id)) | |||
| domain = expression.AND( | |||
| [domain, [("time_window_weekday_ids", "in", week_day_id)]] | |||
There was a problem hiding this comment.
domain = expression.AND(
[domain, [("time_window_weekday_ids", "in", [week_day_id])]]
Two small improvements: * add a hook to change the delivery time format * no need to display seconds, hh:mm is enough
…ry_time_preference The default value introduced by workdays feature breaks the installation of Demo databases as the change is not reflected in sale_partner_delivery_window.
… field is related
version conflict prevents upload to pypi
When copying partner, if the partner's delivery time preference is time window, time window ids should be copied as well.
Currently translated at 100.0% (27 of 27 strings) Translation: stock-logistics-workflow-16.0/stock-logistics-workflow-16.0-stock_partner_delivery_window Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-16-0/stock-logistics-workflow-16-0-stock_partner_delivery_window/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: stock-logistics-workflow-16.0/stock-logistics-workflow-16.0-stock_partner_delivery_window Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-16-0/stock-logistics-workflow-16-0-stock_partner_delivery_window/
Currently translated at 100.0% (27 of 27 strings) Translation: stock-logistics-workflow-16.0/stock-logistics-workflow-16.0-stock_partner_delivery_window Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-16-0/stock-logistics-workflow-16-0-stock_partner_delivery_window/it/
Currently translated at 100.0% (27 of 27 strings) Translation: stock-logistics-workflow-16.0/stock-logistics-workflow-16.0-stock_partner_delivery_window Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-16-0/stock-logistics-workflow-16-0-stock_partner_delivery_window/it/
thienvh332
force-pushed
the
18.0-mig-stock_partner_delivery_window
branch
from
bce6c2f to
019dc92
Compare
AaronHForgeFlow
suggested changes
Feb 28, 2025
|
Hello @thienvh332 will you address the comments, or I should do a supersede? |
|
@ArnauCForgeFlow yes please go ahead :) |
|
Hello @ArnauCForgeFlow , |
|
Closing in favor of #1910 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.