Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMP] stock_split_picking: Add a common for tests / add specific exceptions #1788

Merged
merged 2 commits into from
Jan 31, 2025
Merged

[IMP] stock_split_picking: Add a common for tests / add specific exceptions #1788

merged 2 commits into from
Jan 31, 2025

Conversation

rousseldenis
Copy link
Contributor

@rousseldenis rousseldenis commented Dec 11, 2024 •
edited
Loading

In order to decouple these modifications from OCA/wms#932

And hope for a fast merge

@lmignon @jbaudoux

@rousseldenis rousseldenis added this to the 16.0 milestone Dec 11, 2024
@rousseldenis rousseldenis mentioned this pull request Dec 11, 2024
Open
StefanRijnhart
StefanRijnhart reviewed Jan 30, 2025
View reviewed changes
Copy link
Member

@StefanRijnhart StefanRijnhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rousseldenis Do you agree with @lmignon's suggested changes?

@jbaudoux jbaudoux mentioned this pull request Jan 31, 2025
Merged
@rousseldenis rousseldenis force-pushed the 16.0-imp-stock_split_picking-test-dro branch from d7f5754 to c389b44 Compare January 31, 2025 12:25
@rousseldenis
Copy link
Contributor Author

@jbaudoux @StefanRijnhart ready

@StefanRijnhart
Copy link
Member

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-1788-by-StefanRijnhart-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Jan 31, 2025
@OCA-git-bot
Merge PR #1788 into 16.0
77bb52e 
Signed-off-by StefanRijnhart
@OCA-git-bot
Copy link
Contributor

It looks like something changed on 16.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 16.0-ocabot-merge-pr-1788-by-StefanRijnhart-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Jan 31, 2025
@OCA-git-bot
Merge PR #1788 into 16.0
a4ad13a 
Signed-off-by StefanRijnhart
@OCA-git-bot
Copy link
Contributor

It looks like something changed on 16.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 16.0-ocabot-merge-pr-1788-by-StefanRijnhart-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 1b7d785 into OCA:16.0 Jan 31, 2025
11 of 12 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 524bca6. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmignon lmignon lmignon approved these changes

@StefanRijnhart StefanRijnhart StefanRijnhart approved these changes

@jbaudoux jbaudoux jbaudoux approved these changes

Assignees
No one assigned
Labels
approved enhancement merged 🎉 needs review
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
5 participants
@rousseldenis @StefanRijnhart @OCA-git-bot @lmignon @jbaudoux