[18.0][MIG] stock_picking_batch_set_quantity: Migration to version 18.0 #2107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ocabot migration stock_picking_batch_set_quantity |
pedrobaeza
reviewed
Sep 19, 2025
pedrobaeza
reviewed
Sep 19, 2025
eduezerouali-tecnativa
force-pushed
the
18.0-mig-stock_picking_batch_set_quantity
branch
2 times, most recently
from
1e0adba to
c4c193c
Compare
eduezerouali-tecnativa
force-pushed
the
18.0-mig-stock_picking_batch_set_quantity
branch
from
c4c193c to
9da2542
Compare
eduezerouali-tecnativa
force-pushed
the
18.0-mig-stock_picking_batch_set_quantity
branch
from
9da2542 to
e68e5cc
Compare
|
@pedrobaeza makes more sense now? |
pedrobaeza
reviewed
Oct 4, 2025
| self.ensure_one() | ||
| self._action_assign() | ||
| if self.quantity: | ||
| self.state = "done" |
There was a problem hiding this comment.
This is incorrect, as you can't set state manually. In fact, the idea of the module is to assign quantities, but as I see lately, v18 already pre-assign quantities, so this module doesn't make sense for the new version. On the target version, by default, the reserved quantities wasn't set, so this button was useful for setting that quantities, but now, they are pre-set, so no need of it. Can you confirm?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @Tecnativa TT57680
ping @carlosdauden @pedrobaeza